-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend ESC checks to handle failures #14800
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would love to just move the whole check in one place in https://github.com/PX4/Firmware/tree/d20bca095d08c332ec86b743d949dfa43e552a00/src/modules/commander/Arming/PreFlightCheck
That would eliminate the scattered state in status_flags, global commander state...
Those checks are also executed when flying, moving them to the PreFlightCheck would break it.. |
Signed-off-by: Claudio Micheli <[email protected]>
Signed-off-by: Claudio Micheli <[email protected]>
Signed-off-by: Claudio Micheli <[email protected]>
c608586
to
628d53b
Compare
This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions. |
I'm closing this as stale - please open a new rebased PR with the right commits. |
Resurrected the work in here #16704 |
Describe problem solved by this pull request
This PR extends ESCs checks to handle reported failures by the ESC.
It also ensures that no arming is possible if you have enabled some driver for ESCs reporting telemetry (i.e UAVCAN ESCs) but the telemetry line is disconnected since the vehicle is powered up.
With the previous implementation the vehicle could still arm because the esc checks were not executed if no telemetry data was published.
Such tests can be disabled by using the same parameter that was defined for checking ESCs online status COM_ARM_CHK_ESCS .
Test data / coverage
Tested on a vehicle with custom CAN ESCs.
TODO: