Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend ESC checks to handle failures #14800

Closed
wants to merge 3 commits into from
Closed

Conversation

cmic0
Copy link
Contributor

@cmic0 cmic0 commented Apr 30, 2020

Describe problem solved by this pull request
This PR extends ESCs checks to handle reported failures by the ESC.

It also ensures that no arming is possible if you have enabled some driver for ESCs reporting telemetry (i.e UAVCAN ESCs) but the telemetry line is disconnected since the vehicle is powered up.

With the previous implementation the vehicle could still arm because the esc checks were not executed if no telemetry data was published.

Such tests can be disabled by using the same parameter that was defined for checking ESCs online status COM_ARM_CHK_ESCS .

Test data / coverage
Tested on a vehicle with custom CAN ESCs.

TODO:

  • Test on a vehicle with UAVCAN ESCs

Copy link
Member

@MaEtUgR MaEtUgR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would love to just move the whole check in one place in https://github.com/PX4/Firmware/tree/d20bca095d08c332ec86b743d949dfa43e552a00/src/modules/commander/Arming/PreFlightCheck
That would eliminate the scattered state in status_flags, global commander state...

@cmic0
Copy link
Contributor Author

cmic0 commented May 25, 2020

I would love to just move the whole check in one place in https://github.com/PX4/Firmware/tree/d20bca095d08c332ec86b743d949dfa43e552a00/src/modules/commander/Arming/PreFlightCheck
That would eliminate the scattered state in status_flags, global commander state...

Those checks are also executed when flying, moving them to the PreFlightCheck would break it..
we need to find a way to keep running them even while flying

@cmic0 cmic0 force-pushed the pr-extend-esc-checks branch from c608586 to 628d53b Compare June 8, 2020 08:15
@stale
Copy link

stale bot commented Sep 6, 2020

This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions.

@stale stale bot added the stale label Sep 6, 2020
@LorenzMeier
Copy link
Member

I'm closing this as stale - please open a new rebased PR with the right commits.

@cmic0
Copy link
Contributor Author

cmic0 commented Jan 31, 2021

Resurrected the work in here #16704

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants