-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Driver for distance sensor: vl53l1x #15565
Conversation
Looks good, any test data you can share? I'm wondering about the default ranging mode. Other than that the only thing I'm wondering is it we should keep it closer to the form of the ST Ultra lite driver for future updates, unless it's quite unlikely they'll update it. For reference here was my attempt using the enormous ST driver available at the time. #12575 EDIT: looks like the history was overwritten, and the original work is gone. |
* X7Pro adds CAN driver * UAVCAN timer selection moved to default.cmake * Modify some details about @CUAVcaijie UAVCAN timer selection moved to default.cmake * Put some timer parameters to micro_hal.h from board_config.h. Fix all h7 boards Co-authored-by: honglang <[email protected]>
- single register output is in 2's complement
All the other distance sensors have their default rotation to downwards facing as well
It loads the battery parameters but then overwrites them with hardcoded values and it breaks the ModuleParams parent/child hierarchy. Both is undesired.
The subscription to parameter updates has to get copied otherwise the change detection will not get reset for next time.
This was not a problem before because battery.h included the adc driver and implicitly snprintf was defined through there.
Co-authored-by: Jonathan Hahn <[email protected]>
…SB on new carrier boards) - add console builds (cubepilot_cubeorange_console) for hardware test rack and developers
- BOARD_DSHOT_MOTOR_ASSIGNMENT isn't needed if there's no remapping
I observed stack overflows when executing `uavcan params list`, so the stack size probably needs to be increased. Signed-off-by: Alex Mikhalev <[email protected]>
Regression from d2254c2, I overlooked that they were defined in reverse order.
- this ensures the relevant parameters are marked active immediately before parameter sync - fixes #15872
- run battery_status module on adc_report publications rather than a fixed schedule
Looking forward vl53l1x get supported. |
Very soon I will start to test. The propellers were broken. Later I forgotten.... sorry |
This logs: https://logs.px4.io/plot_app?log=93bd63e7-9c90-4e88-8cee-6853287f1e47 Not sure, what every things works fine, but data from sensor has (distance sensor plot) |
Can you try to cleanup the branch, perhaps squash all your changes into a single commit? It's not currently mergable or really even reviewable. |
Hello.
This is driver for distance sensor VL53L1x from ST. Based on the Ultra lite driver, UM2510; en.STSW-IMG009.