Septentrio v1.15 backport cleanup #23453
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…entrio module (#22904) Having a generic interface over the GPS drivers makes dedicated functionality for each driver harder. Move the Septentrio driver into its own module under the `gnss` driver directory, and let it have its own parameters for only the functionality it requires. This also helps with adding new features because they only need to be implemented for the driver that wants it, simplifying testing.
Internal testing revealed usability issues. Those and some other problems are fixed.
This fixes an incorrect check of the device paths during instantiation of the Septentrio driver that caused the driver to start and not print an error message.
The documentation for `SEP_DUMP_COMM` was quite unclear and users had to use the user guide to find out what exactly it did. The new documentation tries to make the purpose clearer.
Heading wasn't working because of an incorrect check during parsing.
Heading offset was configured as radians but should be configured as degrees on Septentrio receivers. The parameter was already in degrees but the configuration logic was changing it into radians. Also allow the entire allowed range of heading offset values for Septentrio receivers.
|
Note, does this imply a need for docs backport @flyingthingsintothings ? |
|
Yes, the documentation for v1.15 would have to be updated with the same changes that were made to the main documentation. |
|
It's probably my fault, it built correctly but the difference in files might not have been updated when making the pull request and I didn't think to check more than the difference I saw on the web interface. So sorry for that. |
* gnss: update supported baud rates The Septentrio GNSS driver requires certain baud rates to test all the supported baud rates of the receiver. Without these changes, certain "non-standard" ones would print an error to the MAVLink console when the driver was started through the console. * platforms: add missing baudrate defines --------- Co-authored-by: Thomas Frans <[email protected]> Co-authored-by: Julian Oes <[email protected]>
|
I've added the commits from #23415 as well. |
|
v1.15 having conflicting serial configs due to septentrio params: #23714 (comment) |
|
Thanks for the report @bresch I will take a look |
|
This pr was cherry-picked by @dagar no longer needed so I am closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous PR #23386 broke the release branch due to unintentional file overwrites. Hopefully, this PR captures the intention and the functionality.
We need Septentrio to verify this PR builds, flashes, and works before merging.
cc @chiara-septentrio, @flyingthingsintothings