[WIP] TravisCI: fix and improve MacOS build #353
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@julianoes it already finds gstreamer on the MacOS build but still fails because of the protobuf issue. Maybe the bottles weren't updated yet. |
julianoes
reviewed
Oct 14, 2019
| @@ -79,9 +79,25 @@ matrix: | |||
| env: | |||
| - PX4_DOCKER_REPO=px4io/px4-dev-simulation-bionic:2019-10-04 | |||
| - BUILD="source ./scripts/validate_sdf.bash" | |||
| - name: MacOSX 10.14 (Xcode 11.0) build with Gazebo 9 | |||
| - name: MacOSX Sierra (Xcode 9.2) build with Gazebo 7 | |||
There was a problem hiding this comment.
I would drop this version. Supporting 2 and with Catalina 3 is enough.
There was a problem hiding this comment.
I am adding this one so we can have a build pipe for Gazebo 7 also in MacOSX.
| execute_process(COMMAND export Qt5_DIR=$(brew --prefix qt5)) | ||
| execute_process(COMMAND brew --prefix qt5 | ||
| ERROR_QUIET | ||
| OUTPUT_VARIABLE QT5_PREFIX_PATH |
There was a problem hiding this comment.
Ah, actually this one is nicer than my solution.
julianoes
reviewed
Oct 21, 2019
| mkdir Build; | ||
| cd Build && cmake -DENABLE_UNIT_TESTS=On .. && make -j$(sysctl -n hw.physicalcpu) -l$(sysctl -n hw.physicalcpu); make test; | ||
| else | ||
| docker run -it --rm -w ${TRAVIS_BUILD_DIR} --env=CCACHE_DIR="${CCACHE_DIR}" --volume=${CCACHE_DIR}:${CCACHE_DIR}:rw --volume=${TRAVIS_BUILD_DIR}:${TRAVIS_BUILD_DIR}:rw ${PX4_DOCKER_REPO} /bin/bash -e -c "${BUILD}"; |
There was a problem hiding this comment.
@TSC21 what do we use docker for here?
There was a problem hiding this comment.
To build on the Linux distros.
There was a problem hiding this comment.
But that's inside the if [[ "$TRAVIS_OS_NAME" == "osx" ]]; then?
|
Superseded by #354 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of the work being done for bringing
gstreamerto the MacOSX build and make it pass. Adds some new build pipes so to cross test in different MacOSX versions.