Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dependencies on macOS #354

Merged
merged 9 commits into from
Oct 22, 2019
Merged

Fix dependencies on macOS #354

merged 9 commits into from
Oct 22, 2019

Conversation

julianoes
Copy link
Contributor

Now that gstreamer is required by default we actually need to fix getting these dependencies on macOS.

@julianoes julianoes requested a review from TSC21 October 14, 2019 08:52
@TSC21 TSC21 mentioned this pull request Oct 18, 2019
Closed
@srovani srovani mentioned this pull request Oct 19, 2019
Closed
@julianoes julianoes force-pushed the fix-dependencies branch 2 times, most recently from 08227b7 to ee75100 Compare October 21, 2019 12:32
@TSC21
Copy link
Member

TSC21 commented Oct 21, 2019

@julianoes where's Gstreamer being installed here? Should it be installed using homebrew?

On my PR I have gstreamer1.0 being installed through package installer, which seems to do the trick as well. But if you confirm that it can also work using the installed version using homebrew, that's better.

@TSC21 TSC21 mentioned this pull request Oct 22, 2019
Closed
TSC21
TSC21 approved these changes Oct 22, 2019
View reviewed changes
Copy link
Member

@TSC21 TSC21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it could make sense to still have some support for Sierra, but I think for now this should be enough.

@TSC21 TSC21 merged commit 169d482 into master Oct 22, 2019
@TSC21 TSC21 deleted the fix-dependencies branch October 22, 2019 10:42
@julianoes
Copy link
Contributor Author

I think it could make sense to still have some support for Sierra, but I think for now this should be enough.

To say it bluntly: I don't think we can cater for each and everyone and their outdated systems. If people are lazy to stay up to date it's their problem.

@julianoes
Copy link
Contributor Author

And thanks for your help here and merging @TSC21!

@TSC21
Copy link
Member

TSC21 commented Oct 22, 2019

I think it could make sense to still have some support for Sierra, but I think for now this should be enough.

To say it bluntly: I don't think we can cater for each and everyone and their outdated systems. If people are lazy to stay up to date it's their problem.

Yeah, I guess you are right.

And thanks for your help here and merging @TSC21!

No problem!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TSC21 TSC21 TSC21 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julianoes @TSC21