Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PIR] Migrate paddle.nn.Sigmoid into pir #58144

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

MarioLulab
Copy link
Contributor

@MarioLulab MarioLulab commented Oct 17, 2023

PR types

Others

PR changes

Others

Description

新 IR API 推全升级
paddle.nn.Sigmoid 迁移升级至 new ir,并更新单测 本 pr 进行补充.
paddle.nn.Sigmoid 中包含 paddle.nn.functional.sigmoid 调用,故一起进行适配

单测覆盖率:8/14

备注:

  1. test/legacy_test/test_nn_sigmoid_op.py 内的静态图测试涉及 base.backward.append_backward 函数,当前版本会报错:
The type of 'loss' in paddle.static.append_backward must be <class 'paddle.base.framework.Variable'>, but received <class 'paddle.base.libpaddle.pir.OpResult'>. 
  1. 当前版本反向传播机制对 pir api 适配还不完善,待完善后会继续补充与反向传播相关的单测

  2. 部分静态图单测未切换到 pir 体系下,后续需补充

  3. 缺失 TestMKLDNNSigmoidBF16Op 单测

@paddle-bot
Copy link

paddle-bot bot commented Oct 17, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link
Contributor

@Aurelius84 Aurelius84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aurelius84 Aurelius84 merged commit 5e37d2d into PaddlePaddle:develop Oct 17, 2023
@MarioLulab MarioLulab deleted the luqi/pir_api_sigmoid branch October 20, 2023 06:16
hitywt pushed a commit to hitywt/Paddle that referenced this pull request Oct 24, 2023
jiahy0825 pushed a commit to jiahy0825/Paddle that referenced this pull request Oct 26, 2023
danleifeng pushed a commit to danleifeng/Paddle that referenced this pull request Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants