Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PIR] Migrate paddle.nn.Sigmoid into pir #58144

Merged
merged 1 commit into from
Oct 17, 2023
Merged

[PIR] Migrate paddle.nn.Sigmoid into pir #58144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion python/paddle/tensor/ops.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -916,7 +916,7 @@ def sigmoid(x, name=None):
Tensor(shape=[4], dtype=float32, place=Place(cpu), stop_gradient=True,
[0.40131235, 0.45016602, 0.52497917, 0.57444251])
"""
if in_dynamic_mode():
if in_dynamic_or_pir_mode():
return _C_ops.sigmoid(x)
else:
check_variable_and_dtype(
Expand Down
33 changes: 21 additions & 12 deletions test/legacy_test/test_activation_op.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,25 +387,35 @@ def init_dtype(self):
def if_enable_cinn(self):
pass

def test_check_output(self):
self.check_output(check_pir=True)

def test_check_grad(self):
if self.dtype == np.float16:
return
self.check_grad(['X'], 'Out', max_relative_error=0.01, check_prim=True)
self.check_grad(
['X'],
'Out',
max_relative_error=0.01,
check_prim=True,
check_pir=True,
)


class TestSigmoid_Complex64(TestSigmoid):
def init_dtype(self):
self.dtype = np.complex64

def test_check_output(self):
self.check_output(check_prim=False)
self.check_output(check_prim=False, check_pir=True)

def test_check_grad(self):
self.check_grad(
['X'],
'Out',
max_relative_error=0.006,
check_prim=False,
check_pir=True,
)


Expand All @@ -414,11 +424,7 @@ def init_dtype(self):
self.dtype = np.complex128

def test_check_grad(self):
self.check_grad(
['X'],
'Out',
check_prim=False,
)
self.check_grad(['X'], 'Out', check_prim=False, check_pir=True)


class TestSigmoid_ZeroDim(TestSigmoid):
Expand Down Expand Up @@ -459,12 +465,13 @@ def if_enable_cinn(self):

def test_check_output(self):
place = core.CUDAPlace(0)
# elementwise_pow doesn't support bfloat16, skip check_prim here.
self.check_output_with_place(place, check_prim=True)
self.check_output_with_place(place, check_prim=True, check_pir=True)

def test_check_grad(self):
place = core.CUDAPlace(0)
self.check_grad_with_place(place, ['X'], 'Out', check_prim=True)
self.check_grad_with_place(
place, ['X'], 'Out', check_prim=True, check_pir=True
)


'''
Expand Down Expand Up @@ -4628,7 +4635,9 @@ def test_check_grad(self):
TestExpFp32_Prim, check_prim=True, enable_cinn=True, check_prim_pir=True
)
create_test_act_fp16_class(TestExpm1)
create_test_act_fp16_class(TestSigmoid, check_prim=True, enable_cinn=True)
create_test_act_fp16_class(
TestSigmoid, check_prim=True, enable_cinn=True, check_pir=True
)
create_test_act_fp16_class(
TestSilu, check_prim=True, enable_cinn=True, check_prim_pir=True
)
Expand Down Expand Up @@ -4794,7 +4803,7 @@ def test_check_grad(self):
TestExpFp32_Prim, check_prim=True, check_prim_pir=True
)
create_test_act_bf16_class(TestExpm1)
create_test_act_bf16_class(TestSigmoid, check_prim=True)
create_test_act_bf16_class(TestSigmoid, check_prim=True, check_pir=True)
create_test_act_bf16_class(TestSilu, check_prim=True, check_prim_pir=True)
create_test_act_bf16_class(TestLogSigmoid)
create_test_act_bf16_class(TestTanh, check_prim=True, check_prim_pir=True)
Expand Down