Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor CSS files in src/screens/OrganizationDashboard #2513

Closed
AVtheking opened this issue Nov 30, 2024 · 2 comments
Closed

Refactor CSS files in src/screens/OrganizationDashboard #2513

AVtheking opened this issue Nov 30, 2024 · 2 comments
Assignees
@devender18
Labels
feature request good first issue Good for newcomers no-issue-activity No issue activity refactor Refactor the code to improve its quality ui/ux issue related and being worked with the figma file of the Admin UI

Comments

@AVtheking
Copy link
Contributor

Refactor CSS files in src/screens/OrganizationDashboard

To improve the UI/UX of Talawa-Admin we have been working on:

  1. making the application more suitable to color blind users
  2. streamlining all CSS into a single global file

Additional information:

  1. The foundational work for this was completed in this PR:
  2. The desired single CSS file is:
    • src/style/app.module.css

The challenge:

The goal is to convert the CSS file in this subdirectory and all the components related to this screen to use this new design pattern. This means that:

  1. All CSS files in this subdirectory and all the CSS files in related components must be merged into the global CSS file using pre-existing CSS.
  2. All CSS files in this subdirectory and all the CSS files in related components must be deleted after the merge.
  3. The remaining relevant files in this subdirectory must only reference the global CSS file.
  4. All the CSS files in the related components of this subdirectory must adhere to the same guidelines.
@github-actions github-actions bot added refactor Refactor the code to improve its quality ui/ux issue related and being worked with the figma file of the Admin UI unapproved good first issue Good for newcomers labels Nov 30, 2024
@devender18
Copy link
Contributor

@AVtheking could you please assign me this issue?

devender18 added a commit to devender18/talawa-admin that referenced this issue Dec 2, 2024
@devender18
refactor css for OrganizationDashboard screen, closes PalisadoesFound…
f91866d 
…ation#2513
@coderabbitai coderabbitai bot mentioned this issue Dec 2, 2024
Closed
devender18 added a commit to devender18/talawa-admin that referenced this issue Dec 2, 2024
@devender18
refactor OrganizationDashboard css and closes PalisadoesFoundation#2513
9e961ee
devender18 added a commit to devender18/talawa-admin that referenced this issue Dec 3, 2024
@devender18
refactored OrganizationDashboard css/ closes PalisadoesFoundation#2513
be5beb7
@coderabbitai coderabbitai bot mentioned this issue Dec 3, 2024
Merged
devender18 added a commit to devender18/talawa-admin that referenced this issue Dec 3, 2024
@devender18
refactor:OrganizationDashboard_css(fixes PalisadoesFoundation#2513)
06f2cc2
devender18 added a commit to devender18/talawa-admin that referenced this issue Dec 8, 2024
@devender18
refactored: CSS files in src/screens/OrganizationDashboard(fixes: Pal…
b6c7566 
…isadoesFoundation#2513)
devender18 added a commit to devender18/talawa-admin that referenced this issue Dec 8, 2024
@devender18
refactored: CSS files in src/screens/OrganizationDashboard(fixes: Pal…
aa8d72a 
…isadoesFoundation#2513)
@github-actions GitHub Actions
Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Dec 13, 2024
palisadoes added a commit that referenced this issue Dec 13, 2024
@devender18 @duplixx
@dependabot @palisadoes @VanshikaSabharwal @prayanshchh @dhirajudhani
refactored OrganizationDashboard css/ closes #2513 (#2593)
880f6f3 
* refactored OrganizationDashboard css/ closes #2513

* refactor:OrganizationDashboard_css(fixes #2513)

* Plugin and  advertisement screen revamp (#2006)

* advertisement and plugin screen

* added revamped design

* fixes added

* fixed testcases

* chore(deps): bump sass from 1.80.6 to 1.80.7 (#2433)

Bumps [sass](https://github.com/sass/dart-sass) from 1.80.6 to 1.80.7.
- [Release notes](https://github.com/sass/dart-sass/releases)
- [Changelog](https://github.com/sass/dart-sass/blob/main/CHANGELOG.md)
- [Commits](sass/dart-sass@1.80.6...1.80.7)

---
updated-dependencies:
- dependency-name: sass
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps): bump eslint-plugin-import from 2.30.0 to 2.31.0 (#2434)

Bumps [eslint-plugin-import](https://github.com/import-js/eslint-plugin-import) from 2.30.0 to 2.31.0.
- [Release notes](https://github.com/import-js/eslint-plugin-import/releases)
- [Changelog](https://github.com/import-js/eslint-plugin-import/blob/main/CHANGELOG.md)
- [Commits](import-js/eslint-plugin-import@v2.30.0...v2.31.0)

---
updated-dependencies:
- dependency-name: eslint-plugin-import
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps): bump @mui/x-charts from 7.22.1 to 7.22.2 (#2435)

Bumps [@mui/x-charts](https://github.com/mui/mui-x/tree/HEAD/packages/x-charts) from 7.22.1 to 7.22.2.
- [Release notes](https://github.com/mui/mui-x/releases)
- [Changelog](https://github.com/mui/mui-x/blob/v7.22.2/CHANGELOG.md)
- [Commits](https://github.com/mui/mui-x/commits/v7.22.2/packages/x-charts)

---
updated-dependencies:
- dependency-name: "@mui/x-charts"
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps): bump @types/react from 18.3.3 to 18.3.12 (#2436)

Bumps [@types/react](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react) from 18.3.3 to 18.3.12.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react)

---
updated-dependencies:
- dependency-name: "@types/react"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update pull-request.yml

* Update dependabot.yaml

* added docker check to workflow (#2414)

* added docker check to workflow

* made recommended changes to docker check in workflow

* added changes to docker check inn workflow as recommended

* added changes

* updated indentation in pull-request.yml file

* updated indentation in pull-request.yml file

* added Dockerfile and Docker-compose.yml file

* added Dockerfile and Docker-compose.yml file

* updated .docker-ignore file

* added recommended changes by code rabbit

* added recommended changes by code rabbit

* added recommended changes by code rabbit

* added recommended changes by code rabbit

* added recommended changes by code rabbit

* added recommended changes by code rabbit

* properly formatted code

* trying to make docker check pass

* trying to make docker check pass

* updated INSTALLATION.md

* updated INSTALLATION.md

* added recommended changes to INSTALLATION.md

* added recommended changes to INSTALLATION.md

* added recommended changes to INSTALLATION.md

* updated docker workflow

* updated INSTALLATION.md

* eslint-rule-no_unused_vars (#2428)

* Updated pr template with checklist (#2454)

* Updated pr template with checklist

* Additional changes for the PR template

* Changed the url for the PR template

* refactored addOnStore

* refactored addOnEntry v1

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Peter Harrison <[email protected]>
Co-authored-by: Vanshika Sabharwal <[email protected]>
Co-authored-by: prayansh_chhablani <[email protected]>
Co-authored-by: Dhiraj Udhani <[email protected]>

* refactored: CSS files in src/screens/OrgSettings(fixes: #2523) (#2610)

* refactored: CSS files in src/screens/OrgSettings(fixes: #2523)

* refactored: CSS files in src/screens/OrgSettings(fixes: #2523)

* refactored: CSS files in src/screens/OrgSettings(fixes: #2523)

* refactored: CSS files in src/screens/OrgSettings(fixes: #2523)

* Update pull-request.yml

* refactored: CSS files in src/screens/OrganizationDashboard(fixes: #2513)

* refactored: CSS files in src/screens/OrganizationDashboard(fixes: #2513)

* improve import for global css

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Shekhar Patel <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Peter Harrison <[email protected]>
Co-authored-by: Vanshika Sabharwal <[email protected]>
Co-authored-by: prayansh_chhablani <[email protected]>
Co-authored-by: Dhiraj Udhani <[email protected]>
@github-project-automation github-project-automation bot moved this from Backlog to Done in Talawa Admin - Refactoring Dec 13, 2024
@coderabbitai coderabbitai bot mentioned this issue Dec 13, 2024
Closed
This was referenced Dec 24, 2024
Merged
Merged
Merged
This was referenced Dec 28, 2024
Closed
Closed
@coderabbitai coderabbitai bot mentioned this issue Jan 10, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@devender18 devender18

Labels
feature request good first issue Good for newcomers no-issue-activity No issue activity refactor Refactor the code to improve its quality ui/ux issue related and being worked with the figma file of the Admin UI
Projects
2024 New Talawa Admin Screens
Archived in project
Talawa Admin - Refactoring
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@palisadoes @devender18 @AVtheking