Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: src/screens/EventVolunteers/Requests from Jest to Vitest #2547

Closed
VanshikaSabharwal opened this issue Dec 1, 2024 · 5 comments
Closed

Refactor: src/screens/EventVolunteers/Requests from Jest to Vitest #2547

VanshikaSabharwal opened this issue Dec 1, 2024 · 5 comments
Assignees
@bandhan-majumder
Labels
good first issue Good for newcomers refactor Refactor the code to improve its quality test Testing application

Comments

@VanshikaSabharwal
Copy link
Contributor

Is your feature request related to a problem? Please describe.
This file is currently tested using Jest. As part of our migration to Vitest, we need to refactor this file's test cases to align with Vitest's syntax and features.

Acceptance Criteria

  1. Replace Jest-specific functions and mocks with Vitest equivalents
  2. Ensure all tests in src/screens/EventVolunteers/Requests pass after migration using npm run test:vitest
  3. Maintain the test coverage for the file as 100% after migration
  4. Upload a video or photo for this specific file coverage is 100% in the PR description

Additional context

Potential internship candidates

Please read this if you are planning to apply for a Palisadoes Foundation internship
@github-actions github-actions bot added documentation Improvements or additions to documentation refactor Refactor the code to improve its quality test Testing application unapproved labels Dec 1, 2024
@palisadoes palisadoes added good first issue Good for newcomers and removed documentation Improvements or additions to documentation feature request labels Dec 3, 2024
This was referenced Dec 6, 2024
Closed
Closed
@bandhan-majumder
Copy link
Contributor

Can I work on this?

bandhan-majumder pushed a commit to bandhan-majumder/talawa-admin that referenced this issue Dec 12, 2024
Refactor: jest to vitest : Fixes PalisadoesFoundation#2547
80b6f36
@bandhan-majumder bandhan-majumder mentioned this issue Dec 12, 2024
Merged
bandhan-majumder pushed a commit to bandhan-majumder/talawa-admin that referenced this issue Dec 12, 2024
Refactor: jest to vitest : Fixes PalisadoesFoundation#2547
3484f6e
palisadoes pushed a commit that referenced this issue Dec 12, 2024
@bandhan-majumder
Refactor: jest to vitest : Fixes #2547 (#2641)
cb5c255 
* Refactor: jest to vitest : Fixes #2547

* Refactor: jest to vitest : Fixes #2547

* updated src/screens/EventVolunteers/Requests.spec.tsx

---------

Co-authored-by: bandhan-majumder <[email protected]>
Co-authored-by: Bandhan Majumder <[email protected]>
@github-project-automation github-project-automation bot moved this from Backlog to Done in Talawa-Admin (Tests) Dec 12, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Done in Talawa Admin - Refactoring Dec 12, 2024
@bandhan-majumder
Copy link
Contributor

Unassigning myself as this is completed.

@bandhan-majumder bandhan-majumder removed their assignment Dec 12, 2024
@bandhan-majumder
Copy link
Contributor

hi @palisadoes . I unassigned myself as the issue was closed with a successfully merged PR. But I have been reassigned. Can I unassign myself so that I can take other issues to work with?

@palisadoes
Copy link
Contributor

We only apply the policy to open issues

@bandhan-majumder
Copy link
Contributor

Sorry my bad. Thank you.

This was referenced Dec 13, 2024
Closed
Closed
This was referenced Dec 21, 2024
Merged
Merged
Merged
Closed
Merged
This was referenced Dec 29, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bandhan-majumder bandhan-majumder

Labels
good first issue Good for newcomers refactor Refactor the code to improve its quality test Testing application
Projects
Talawa Admin - Refactoring
Status: Done
Talawa-Admin (Tests)
Archived in project
Milestone
No milestone
Development

No branches or pull requests
4 participants
@palisadoes @dhanagopu @bandhan-majumder @VanshikaSabharwal