-
-
Notifications
You must be signed in to change notification settings - Fork 813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor : Vitest to SidePanel Component #2735
Refactor : Vitest to SidePanel Component #2735
Conversation
WalkthroughThe pull request focuses on adding documentation comments to the Changes
Assessment against linked issues
Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Our Pull Request Approval ProcessThanks for contributing! Testing Your CodeRemember, your PRs won't be reviewed until these criteria are met:
Our policies make our code better. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop-postgres #2735 +/- ##
=====================================================
+ Coverage 75.84% 87.08% +11.24%
=====================================================
Files 295 312 +17
Lines 7289 8148 +859
Branches 1593 1840 +247
=====================================================
+ Hits 5528 7096 +1568
+ Misses 1497 875 -622
+ Partials 264 177 -87 ☔ View full report in Codecov by Sentry. |
@shivasankaran18 Did you complete all the steps discussed in the issue? |
Yes @Cioppolo14 ...the test file does not have jest specific mocking...So it also works seamlessly with Vitest |
This was a very minor change. |
ea264ce
into
PalisadoesFoundation:develop-postgres
What kind of change does this PR introduce?
Added Vitest to src/components/AddOn/support/components/SidePanel/SidePanel.
Issue Number: 2476
Fixes #2476
Did you add tests for your changes?
Yes
Snapshots/Videos:
If relevant, did you update the documentation?
Summary
Migrated the testing framework to Vitest.
Updated all test files and configurations to be compatible with Vitest's syntax and features.
Have you read the contributing guide?
Yes
Summary by CodeRabbit
SidePanel
component to clarify the purpose of theprops
object and the test case.