-
-
Notifications
You must be signed in to change notification settings - Fork 813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrated src/components/RecurrenceOptions/* from Jest to Vitest. #2911
Migrated src/components/RecurrenceOptions/* from Jest to Vitest. #2911
Conversation
Our Pull Request Approval ProcessThanks for contributing! Testing Your CodeRemember, your PRs won't be reviewed until these criteria are met:
Our policies make our code better. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
WalkthroughThis pull request focuses on migrating test files for the Changes
Assessment against linked issues
Possibly related issues
Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (2)
🧰 Additional context used📓 Learnings (1)📓 Common learnings
🔇 Additional comments (6)src/components/RecurrenceOptions/RecurrenceOptions.spec.tsx (3)
Good job swapping out the Jest imports for Vitest. This change is aligned with your migration objective.
Replacing
These updates cleanly replace src/components/RecurrenceOptions/CustomRecurrence.spec.tsx (3)
Similar to the other file, switching to Vitest imports is correct for the new test framework.
Importing the actual DateTimePicker and aliasing it works seamlessly under Vitest. Good usage of
Adopting Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
@coderabbitai full review |
✅ Actions performedFull review triggered. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop-postgres #2911 +/- ##
=====================================================
+ Coverage 58.52% 87.99% +29.47%
=====================================================
Files 299 316 +17
Lines 7414 8265 +851
Branches 1621 1866 +245
=====================================================
+ Hits 4339 7273 +2934
+ Misses 2828 779 -2049
+ Partials 247 213 -34 ☔ View full report in Codecov by Sentry. |
@coderabbitai full review |
✅ Actions performedFull review triggered. |
d99fc8b
into
PalisadoesFoundation:develop-postgres
What kind of change does this PR introduce?
This PR will migrate the src/components/RecurrenceOptions/* from Jest to Vitest.
Issue Number:
Fixes #2807
Did you add tests for your changes?
Yes
Snapshots/Videos:
If relevant, did you update the documentation?
No
Does this PR introduce a breaking change?
No
Have you read the contributing guide?
Yes
Summary by CodeRabbit
CustomRecurrence.spec.tsx
andRecurrenceOptions.spec.tsx
.@mui/x-date-pickers/DateTimePicker
andreact-toastify
.