tests for src/graphql/types/Event/updater.ts added
#3180
Conversation
|
Warning Rate limit exceeded@amaan-aly246 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 13 minutes and 15 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
WalkthroughThis pull request introduces a dedicated resolver function, Changes
Assessment against linked issues
Possibly related issues
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Our Pull Request Approval ProcessThanks for contributing! Testing Your CodeRemember, your PRs won't be reviewed until these criteria are met:
Our policies make our code better. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
Our Pull Request Approval ProcessThanks for contributing! Testing Your CodeRemember, your PRs won't be reviewed until these criteria are met:
Our policies make our code better. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (2)
src/graphql/types/Event/updater.spec.ts(1 hunks)src/graphql/types/Event/updater.ts(1 hunks)
🧰 Additional context used
🪛 GitHub Actions: Pull request workflow
src/graphql/types/Event/updater.spec.ts
[error] 186-186: Formatter would have printed the following content indicating a formatting issue.
[error] 188-188: Some errors were emitted while running checks.
🔇 Additional comments (4)
src/graphql/types/Event/updater.ts (2)
1-9: LGTM! Clean imports and type definitions.The imports are well-organized, and type definitions are properly structured.
93-101: LGTM! Clean Event type implementation.The Event type implementation is well-structured and properly uses the resolver function.
src/graphql/types/Event/updater.spec.ts (2)
1-49: LGTM! Well-structured test setup with comprehensive mocks.The test setup is clean with well-defined mock objects and contexts.
50-185: LGTM! Comprehensive test coverage.The test cases cover all critical paths including authentication, authorization, and error scenarios.
Also applies to: 191-197
Our Pull Request Approval ProcessThanks for contributing! Testing Your CodeRemember, your PRs won't be reviewed until these criteria are met:
Our policies make our code better. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop-postgres #3180 +/- ##
====================================================
+ Coverage 40.11% 40.33% +0.21%
====================================================
Files 455 455
Lines 33543 33558 +15
Branches 433 446 +13
====================================================
+ Hits 13457 13534 +77
+ Misses 20086 20024 -62 ☔ View full report in Codecov by Sentry. |
Our Pull Request Approval ProcessThanks for contributing! Testing Your CodeRemember, your PRs won't be reviewed until these criteria are met:
Our policies make our code better. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
There was a problem hiding this comment.
Actionable comments posted: 4
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (2)
src/graphql/types/Event/updater.spec.ts(1 hunks)src/graphql/types/Event/updater.ts(1 hunks)
🧰 Additional context used
🪛 GitHub Actions: Pull request workflow
src/graphql/types/Event/updater.ts
[warning] 20-20: Formatter would have printed the following content: message: 'You must be authenticated to access event updater information.' should be formatted correctly.
[warning] 47-47: Formatter would have printed the following content: message: 'You must be authenticated to access event updater information.' should be formatted correctly.
[warning] 92-92: Formatter would have printed the following content: message: 'Event updater not found in the database. This indicates a data integrity issue.' should be formatted correctly.
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Analyse Code With CodeQL (typescript)
Our Pull Request Approval ProcessThanks for contributing! Testing Your CodeRemember, your PRs won't be reviewed until these criteria are met:
Our policies make our code better. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
|
@palisadoes @Cioppolo14 please review the PR. |
palisadoes
merged commit 3266337
into
PalisadoesFoundation:develop-postgres
What kind of change does this PR introduce?
created resolver function and added tests
Issue Number:
Fixes #3069
Snapshots/Videos:
If relevant, did you update the documentation?
No
Does this PR introduce a breaking change?
No
Checklist
CodeRabbit AI Review
Test Coverage
Other information
Have you read the contributing guide?
Summary by CodeRabbit
Refactor
Tests