Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overflow on set_url page in landscape mode #1381

Closed
Ayush0Chaudhary opened this issue Dec 30, 2022 · 6 comments · Fixed by #1382
Closed

Overflow on set_url page in landscape mode #1381

Ayush0Chaudhary opened this issue Dec 30, 2022 · 6 comments · Fixed by #1382
Assignees
@Ayush0Chaudhary
Labels
bug Something isn't working

Comments

@Ayush0Chaudhary
Copy link
Contributor

Describe the bug
when we rotate the screen in landscape-mode on set_url page their is a overflow of 110 pixels in my device.
also we cannot set url in landscape mode.
To Reproduce
Steps to reproduce the behavior:

  1. open the app
  2. go to set url page
  3. rotate the phone by 90 degrees

Expected behavior
It should have not overflowed and alowwed to set url in landscape mode

Actual behavior
It overflowed

Screenshots
issue
issue2
@Ayush0Chaudhary Ayush0Chaudhary added the bug Something isn't working label Dec 30, 2022
@github-actions github-actions bot added the unapproved Unapproved, needs to be triaged label Dec 30, 2022
@Ayush0Chaudhary
Copy link
Contributor Author

Ayush0Chaudhary commented Dec 30, 2022 •
edited
Loading

I want to solve this issue @palisadoes @SiddheshKukade

As solution I can fix it in portrait mode or just fix the overflow?

What do you suggest, which approach I should follow??

@Ayush0Chaudhary
Copy link
Contributor Author

@SiddheshKukade I want to work on this.

@palisadoes palisadoes removed the unapproved Unapproved, needs to be triaged label Jan 4, 2023
Ayush0Chaudhary added a commit to Ayush0Chaudhary/talawa that referenced this issue Jan 5, 2023
@Ayush0Chaudhary
Fixes PalisadoesFoundation#1381 QR landscape overflow
99e6db3
@Ayush0Chaudhary Ayush0Chaudhary mentioned this issue Jan 5, 2023
Merged
Ayush0Chaudhary added a commit to Ayush0Chaudhary/talawa that referenced this issue Jan 5, 2023
@Ayush0Chaudhary
Fixes PalisadoesFoundation#1381 QR landscape overflow
4c5e4e1
Ayush0Chaudhary added a commit to Ayush0Chaudhary/talawa that referenced this issue Jan 6, 2023
@Ayush0Chaudhary
Add test for fixes in PalisadoesFoundation#1381
6a73046
@TheHazeEffect
Copy link
Contributor

@SiddheshKukade I want to work on this.

Hey, for now we're thinking of locking the app to be portrait mode only

@palisadoes
Copy link
Contributor

@Ayush0Chaudhary Are you still working on this?

@Ayush0Chaudhary
Copy link
Contributor Author

I completed this issue and raised the PR.
The PR was not reviewed.

There was some issue with your code dev report, I commented my research on code dev report issue in the PR.

@Ayush0Chaudhary
Copy link
Contributor Author

@palisadoes

palisadoes pushed a commit that referenced this issue Jan 29, 2023
@Ayush0Chaudhary
Fixes #1381 Forcing App in portrait mode. (#1382)
a8ca909 
* fixes overflow

* Fixes #1381 QR landscape overflow

* Fixes #1381 QR landscape overflow

* Add test for fixes in #1381

* Fixed the Mobile App in Portrait Mode.

* Remove unecessary MediaQuery in SetUrlViewModel

* Change the file to original

* fix set_url_view_model_test

* Changed the previous test that reinitialized hive

* removed unused statements

* Update app_setting_page_test.dart

* Update app_setting_page_test.dart

* Update app_setting_page_test.dart
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ayush0Chaudhary Ayush0Chaudhary

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #1381 Forcing App in portrait mode. Ayush0Chaudhary/talawa
3 participants
@palisadoes @TheHazeEffect @Ayush0Chaudhary