Fixes #1381 Forcing App in portrait mode. #1382

Ayush0Chaudhary · 2023-01-05T18:00:58Z

What kind of change does this PR introduce?

Issue Number:

Fixes #1381

Did you add tests for your changes?
no

Snapshots/Videos:

overflow.mp4

If relevant, did you update the documentation?

Summary

fixed the overflow of the qr in landscape mode. I used LayoutBuilder to manage the constraints

Does this PR introduce a breaking change?
NO

Other information
NO

Have you read the contributing guide?
yes

palisadoes · 2023-01-05T19:00:53Z

@Ayush0Chaudhary Please update the test cases for this file based on your updates. We need to keep increasing our test code coverage.

SiddheshKukade

Changes are looking fine to be merged. We also need to update the tests for this file.

palisadoes

@Ayush0Chaudhary Please update the test cases for this file based on your updates. We need to keep increasing our test code coverage.

Ayush0Chaudhary · 2023-01-06T20:16:40Z

Adding the changes asap!

Ayush0Chaudhary · 2023-01-07T09:59:54Z

I am not able to add test for portrait mode, can you help or direct me to some resource I can refer to

Couldn't find proper method on google too.
@palisadoes @SiddheshKukade

SiddheshKukade · 2023-01-07T13:20:55Z

I am not able to add test for portrait mode, can you help or direct me to some resource I can refer to

Couldn't find proper method on google too.
@palisadoes @SiddheshKukade

Hi, you can refer to exisiting test files. Also keep an on coverage if it's 100 percent then no need to add further tests

Ayush0Chaudhary · 2023-01-08T11:22:14Z

orientation setter is only used by me in whole app

I read 8-9 tests
But couldn't find orientation setter, the default size of screen in unittest is
Size(2400.0, 1800.0)
thus it is testing for landscape but not portrait

@palisadoes @SiddheshKukade can you help with this??

palisadoes · 2023-01-08T17:00:23Z

@Ayush0Chaudhary We have decided that it will be best to disable landscape completely as it will make the app more difficult to use.

However we should think of ways to have a standard error when overflows like this occur. Please also work with @TheHazeEffect as he says he knows of a potential solution. This will be a good addition to the code base.

There is another PR #1380 where we are working on a widget to create standardized error messages. Coordinating with that PR would be good too so that you don't duplicate work.

Ayush0Chaudhary · 2023-01-09T02:29:05Z

There won't be duplicate work, as I am also the author of #1380 @palisadoes. I will disable the landscape in my next Commit ASAP!
@TheHazeEffect Can you suggest how can we go after this issue??

Ayush0Chaudhary · 2023-01-09T09:34:33Z

@palisadoes can you merge the PR now??

palisadoes · 2023-01-09T12:56:19Z

@TheHazeEffect @SiddheshKukade please review

SiddheshKukade

I'm not sure why you've deleted the set_url_view_model_test.dart file. I think It was just a test file to check if the QR works.

Also, I will suggest renaming the PR to something like "Forcing Portrait Mode on the app"

SiddheshKukade · 2023-01-10T05:07:34Z

lib/main.dart

+    fs.SystemChrome.setPreferredOrientations(
+      [
+        fs.DeviceOrientation.portraitUp,
+        fs.DeviceOrientation.portraitDown,
+      ],
+    );


This looks OK to lock the app in portrait mode. 👍🏻

codecov-commenter · 2023-01-10T06:32:31Z

Codecov Report

Merging #1382 (b46d44a) into develop (0c9dbc2) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff             @@
##           develop    #1382      +/-   ##
===========================================
- Coverage    70.82%   70.80%   -0.02%     
===========================================
  Files          146      146              
  Lines         7207     7209       +2     
===========================================
  Hits          5104     5104              
- Misses        2103     2105       +2

Impacted Files	Coverage Δ
lib/main.dart	`6.66% <0.00%> (-0.12%)`	⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Ayush0Chaudhary · 2023-01-10T06:37:13Z

I'm not sure why you've deleted the set_url_view_model_test.dart file. I think It was just a test file to check if the QR works.

Also, I will suggest renaming the PR to something like "Forcing Portrait Mode on the app"

I made the changes, @SiddheshKukade , I am new to GitHub, apologies.

palisadoes · 2023-01-10T17:17:16Z

@Ayush0Chaudhary Our code coverage levels have decreased with this PR. Please add tests that cover the changes you made.

palisadoes

@Ayush0Chaudhary Please update the test cases for this file based on your updates. We need to keep increasing our test code coverage.

Ayush0Chaudhary · 2023-01-19T21:17:22Z

@palisadoes @SiddheshKukade All test are passed!!

SiddheshKukade · 2023-01-20T18:39:37Z

Please update the code as the tests here are failing.

Ayush0Chaudhary · 2023-01-26T11:38:04Z

Ayush0Chaudhary · 2023-01-26T11:39:31Z

@SiddheshKukade please check, code coverage is 68.3% now.

noman2002 · 2023-01-26T18:23:30Z

@Ayush0Chaudhary the code coverage for main.dart is currently at 6.66%. Please try to get it to 100%.

Ayush0Chaudhary · 2023-01-27T02:46:45Z

Ok got it

Ayush0Chaudhary · 2023-01-27T20:48:27Z

@noman2002 Can we make this file unit-test as different issue?? I am facing difficulties, I cannot examples for main.dart test anywhere??

noman2002 · 2023-01-27T20:51:19Z

@noman2002 Can we make this file unit-test as different issue?? I am facing difficulties, I cannot examples for main.dart test anywhere??

@palisadoes what you say ?

palisadoes · 2023-01-27T21:02:08Z

Yes, please create a separate issue for the tests

Ayush0Chaudhary · 2023-01-27T21:40:30Z

So can we merge this PR ??@noman2002

test/widget_tests/after_auth_screens/app_settings/app_setting_page_test.dart

Ayush0Chaudhary · 2023-01-27T22:28:24Z

@noman2002 made the changes you asked for

noman2002

Please resolve the conflicts.

Ayush0Chaudhary · 2023-01-28T19:53:58Z

@noman2002 please review.
@palisadoes

Ayush0Chaudhary · 2023-01-28T20:33:56Z

@palisadoes @SiddheshKukade @TheHazeEffect please approve the changes!!

Ayush0Chaudhary · 2023-01-29T09:00:47Z

@palisadoes is there a problem you see with PR, I can change it if you want

noman2002 · 2023-01-29T09:37:37Z

@palisadoes is there a problem you see with PR, I can change it if you want

There is a huge time difference between India and Jamaica. Wait for him to review the changes.

Ayush0Chaudhary · 2023-01-29T14:23:50Z

@palisadoes is there a problem you see with PR, I can change it if you want

There is a huge time difference between India and Jamaica. Wait for him to review the changes.

ok @noman2002, thank you

Ayush0Chaudhary added 3 commits January 5, 2023 00:43

fixes overflow

d9a8489

Fixes PalisadoesFoundation#1381 QR landscape overflow

99e6db3

Fixes PalisadoesFoundation#1381 QR landscape overflow

4c5e4e1

palisadoes requested review from CyberWake and SiddheshKukade January 5, 2023 19:01

SiddheshKukade previously approved these changes Jan 6, 2023

View reviewed changes

palisadoes requested changes Jan 6, 2023

View reviewed changes

Add test for fixes in PalisadoesFoundation#1381

6a73046

Ayush0Chaudhary dismissed SiddheshKukade’s stale review via 6a73046 January 6, 2023 21:31

palisadoes requested a review from TheHazeEffect January 8, 2023 16:55

Ayush0Chaudhary added 3 commits January 9, 2023 14:45

Fixed the Mobile App in Portrait Mode.

6b68c56

Remove unecessary MediaQuery in SetUrlViewModel

4736e70

Change the file to original

21c447f

SiddheshKukade reviewed Jan 10, 2023

View reviewed changes

Ayush0Chaudhary changed the title ~~Fixes #1381 QR landscape overflow~~ Fixes #1381 Forcing App in portrait mode. Jan 10, 2023

fix set_url_view_model_test

1a57bfc

Ayush0Chaudhary force-pushed the Ayush0Chaudhary/fix-landscape-overflow branch from 01046e2 to 1a57bfc Compare January 10, 2023 06:31

palisadoes requested changes Jan 10, 2023

View reviewed changes

removed unused statements

258fbd8

Merge branch 'develop' into Ayush0Chaudhary/fix-landscape-overflow

f255a2b

noman2002 requested a review from SiddheshKukade January 26, 2023 13:54

Ayush0Chaudhary mentioned this pull request Jan 26, 2023

Views: Create tests for signup_details.dart #1247

Closed

noman2002 requested changes Jan 27, 2023

View reviewed changes

test/widget_tests/after_auth_screens/app_settings/app_setting_page_test.dart Show resolved Hide resolved

Update app_setting_page_test.dart

5c6ab5c

noman2002 self-requested a review January 28, 2023 15:24

noman2002 requested changes Jan 28, 2023

View reviewed changes

Ayush0Chaudhary added 3 commits January 29, 2023 00:50

Merge branch 'develop' into Ayush0Chaudhary/fix-landscape-overflow

de75065

Update app_setting_page_test.dart

2d7a169

Update app_setting_page_test.dart

b46d44a

noman2002 approved these changes Jan 28, 2023

View reviewed changes

palisadoes approved these changes Jan 29, 2023

View reviewed changes

palisadoes merged commit a8ca909 into PalisadoesFoundation:develop Jan 29, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixes #1381 Forcing App in portrait mode. #1382

Fixes #1381 Forcing App in portrait mode. #1382

Ayush0Chaudhary commented Jan 5, 2023

palisadoes commented Jan 5, 2023

SiddheshKukade left a comment

palisadoes left a comment

Ayush0Chaudhary commented Jan 6, 2023

Ayush0Chaudhary commented Jan 7, 2023

SiddheshKukade commented Jan 7, 2023 •

edited

Loading

Ayush0Chaudhary commented Jan 8, 2023

palisadoes commented Jan 8, 2023

Ayush0Chaudhary commented Jan 9, 2023

Ayush0Chaudhary commented Jan 9, 2023

palisadoes commented Jan 9, 2023

SiddheshKukade left a comment •

edited

Loading

SiddheshKukade Jan 10, 2023

codecov-commenter commented Jan 10, 2023 •

edited

Loading

Ayush0Chaudhary commented Jan 10, 2023 •

edited

Loading

palisadoes commented Jan 10, 2023

palisadoes left a comment

Ayush0Chaudhary commented Jan 19, 2023 •

edited

Loading

SiddheshKukade commented Jan 20, 2023

Ayush0Chaudhary commented Jan 26, 2023

Ayush0Chaudhary commented Jan 26, 2023

noman2002 commented Jan 26, 2023

Ayush0Chaudhary commented Jan 27, 2023

Ayush0Chaudhary commented Jan 27, 2023

noman2002 commented Jan 27, 2023

palisadoes commented Jan 27, 2023

Ayush0Chaudhary commented Jan 27, 2023

Ayush0Chaudhary commented Jan 27, 2023

noman2002 left a comment

Ayush0Chaudhary commented Jan 28, 2023

Ayush0Chaudhary commented Jan 28, 2023

Ayush0Chaudhary commented Jan 29, 2023

noman2002 commented Jan 29, 2023

Ayush0Chaudhary commented Jan 29, 2023

Fixes #1381 Forcing App in portrait mode. #1382

Fixes #1381 Forcing App in portrait mode. #1382

Conversation

Ayush0Chaudhary commented Jan 5, 2023

palisadoes commented Jan 5, 2023

SiddheshKukade left a comment

Choose a reason for hiding this comment

palisadoes left a comment

Choose a reason for hiding this comment

Ayush0Chaudhary commented Jan 6, 2023

Ayush0Chaudhary commented Jan 7, 2023

SiddheshKukade commented Jan 7, 2023 • edited Loading

Ayush0Chaudhary commented Jan 8, 2023

palisadoes commented Jan 8, 2023

Ayush0Chaudhary commented Jan 9, 2023

Ayush0Chaudhary commented Jan 9, 2023

palisadoes commented Jan 9, 2023

SiddheshKukade left a comment • edited Loading

Choose a reason for hiding this comment

SiddheshKukade Jan 10, 2023

Choose a reason for hiding this comment

codecov-commenter commented Jan 10, 2023 • edited Loading

Codecov Report

Ayush0Chaudhary commented Jan 10, 2023 • edited Loading

palisadoes commented Jan 10, 2023

palisadoes left a comment

Choose a reason for hiding this comment

Ayush0Chaudhary commented Jan 19, 2023 • edited Loading

SiddheshKukade commented Jan 20, 2023

Ayush0Chaudhary commented Jan 26, 2023

Ayush0Chaudhary commented Jan 26, 2023

noman2002 commented Jan 26, 2023

Ayush0Chaudhary commented Jan 27, 2023

Ayush0Chaudhary commented Jan 27, 2023

noman2002 commented Jan 27, 2023

palisadoes commented Jan 27, 2023

Ayush0Chaudhary commented Jan 27, 2023

Ayush0Chaudhary commented Jan 27, 2023

noman2002 left a comment

Choose a reason for hiding this comment

Ayush0Chaudhary commented Jan 28, 2023

Ayush0Chaudhary commented Jan 28, 2023

Ayush0Chaudhary commented Jan 29, 2023

noman2002 commented Jan 29, 2023

Ayush0Chaudhary commented Jan 29, 2023

SiddheshKukade commented Jan 7, 2023 •

edited

Loading

SiddheshKukade left a comment •

edited

Loading

codecov-commenter commented Jan 10, 2023 •

edited

Loading

Ayush0Chaudhary commented Jan 10, 2023 •

edited

Loading

Ayush0Chaudhary commented Jan 19, 2023 •

edited

Loading