Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1381 Forcing App in portrait mode. #1382

Merged
merged 15 commits into from
Jan 29, 2023
Merged

Fixes #1381 Forcing App in portrait mode. #1382

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
d9a8489
fixes overflow
Ayush0Chaudhary Jan 4, 2023
99e6db3
Fixes #1381 QR landscape overflow
Ayush0Chaudhary Jan 5, 2023
4c5e4e1
Fixes #1381 QR landscape overflow
Ayush0Chaudhary Jan 5, 2023
6a73046
Add test for fixes in #1381
Ayush0Chaudhary Jan 6, 2023
6b68c56
Fixed the Mobile App in Portrait Mode.
Ayush0Chaudhary Jan 9, 2023
4736e70
Remove unecessary MediaQuery in SetUrlViewModel
Ayush0Chaudhary Jan 9, 2023
21c447f
Change the file to original
Ayush0Chaudhary Jan 9, 2023
1a57bfc
fix set_url_view_model_test
Ayush0Chaudhary Jan 10, 2023
ebdbf51
Changed the previous test that reinitialized hive
Ayush0Chaudhary Jan 19, 2023
258fbd8
removed unused statements
Ayush0Chaudhary Jan 19, 2023
f255a2b
Merge branch 'develop' into Ayush0Chaudhary/fix-landscape-overflow
Ayush0Chaudhary Jan 26, 2023
5c6ab5c
Update app_setting_page_test.dart
Ayush0Chaudhary Jan 27, 2023
de75065
Merge branch 'develop' into Ayush0Chaudhary/fix-landscape-overflow
Ayush0Chaudhary Jan 28, 2023
2d7a169
Update app_setting_page_test.dart
Ayush0Chaudhary Jan 28, 2023
b46d44a
Update app_setting_page_test.dart
Ayush0Chaudhary Jan 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions lib/main.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import 'package:firebase_core/firebase_core.dart';
import 'package:firebase_messaging/firebase_messaging.dart';
import 'package:flutter/foundation.dart';
import 'package:flutter/material.dart';
import 'package:flutter/services.dart' as fs;
import 'package:flutter_local_notifications/flutter_local_notifications.dart';
import 'package:flutter_localizations/flutter_localizations.dart';
import 'package:hive/hive.dart';
Expand Down Expand Up @@ -140,6 +141,12 @@ class _MyAppState extends State<MyApp> {
initQuickActions();
FetchPluginList();
super.initState();
fs.SystemChrome.setPreferredOrientations(
[
fs.DeviceOrientation.portraitUp,
fs.DeviceOrientation.portraitDown,
],
);
Comment on lines +144 to +149
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks OK to lock the app in portrait mode. 👍🏻

}

initQuickActions() async {
Expand Down
23 changes: 14 additions & 9 deletions test/widget_tests/after_auth_screens/app_settings/app_setting_page_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,16 @@
import 'dart:io';

import 'package:flutter/material.dart';
import 'package:flutter_localizations/flutter_localizations.dart';
import 'package:flutter_test/flutter_test.dart';
import 'package:hive/hive.dart';
import 'package:mockito/mockito.dart';
import 'package:provider/provider.dart';
import 'package:talawa/constants/constants.dart';
import 'package:talawa/constants/custom_theme.dart';
import 'package:talawa/models/language/language_model.dart';
import 'package:talawa/models/organization/org_info.dart';
import 'package:talawa/models/user/user_info.dart';
import 'package:talawa/router.dart' as router;
import 'package:talawa/services/graphql_config.dart';
import 'package:talawa/services/navigation_service.dart';
Expand Down Expand Up @@ -80,19 +85,19 @@ Widget createChangePassScreenDark({ThemeMode themeMode = ThemeMode.dark}) =>
);

Future<void> main() async {
TestWidgetsFlutterBinding.ensureInitialized();
testSetupLocator();
TestWidgetsFlutterBinding.ensureInitialized();
locator<GraphqlConfig>().test();
locator<SizeConfig>().test();
noman2002 marked this conversation as resolved.
Show resolved Hide resolved
final Directory dir = Directory('temporaryPath');
Hive
..init(dir.path)
..registerAdapter(UserAdapter())
..registerAdapter(OrgInfoAdapter());
await Hive.openBox<User>('currentUser');
await Hive.openBox<OrgInfo>('currentOrg');
await Hive.openBox('url');

// final Directory dir = Directory('temporaryPath');
// Hive
// ..init(dir.path)
// ..registerAdapter(UserAdapter())
// ..registerAdapter(OrgInfoAdapter());
// await Hive.openBox<User>('currentUser');
// await Hive.openBox<OrgInfo>('currentOrg');
// await Hive.openBox('url');
group('Setting Page Screen Widget Test in dark mode', () {
testWidgets("Testing if Settings Screen shows up", (tester) async {
await tester.pumpWidget(createChangePassScreenDark());
Expand Down