Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved testing select_contact #1645

Closed
wants to merge 9 commits into from
Closed
Changes from 6 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions .github/workflows/codecov.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
# - name: Upload coverage reports to Codecov
# uses: codecov/codecov-action@v3

name: Upload coverage reports to Codecov
on:
push:
branches:
- main
pull_request:
jobs:
build:
runs-on: ubuntu-latest
steps:
- name: Checkout code
uses: actions/checkout@v2
- name: Setup Flutter
uses: subosito/flutter-action@v1
with:
flutter-version: '3.7.1'
- name: Install dependencies
run: flutter pub get
- name: Run tests with coverage
run: flutter test --coverage
- name: Upload coverage reports to Codecov
uses: codecov/codecov-action@v3

Kraken005 marked this conversation as resolved.
Show resolved Hide resolved
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
@@ -40,3 +40,4 @@ Get familiar with `talawa`:
1. Want to contribute? Look at [CONTRIBUTING.md](CONTRIBUTING.md) to get started.
1. Visit the [Talawa GitHub](https://github.com/PalisadoesFoundation/talawa) to see the code.

[![codecov](https://codecov.io/gh/Kraken005/talawa/branch/develop/graph/badge.svg)](https://codecov.io/gh/Kraken005/talawa)
4 changes: 3 additions & 1 deletion lib/views/base_view.dart
Original file line number Diff line number Diff line change
@@ -2,10 +2,12 @@ import 'package:flutter/material.dart';
import 'package:provider/provider.dart';
import 'package:talawa/locator.dart';

//import '../../test/views/after_auth_screens/chat/select_contact_test.dart';

class BaseView<T extends ChangeNotifier> extends StatefulWidget {
const BaseView({
required this.builder,
this.onModelReady,
this.onModelReady,
});
final Function(T)? onModelReady;
final Widget Function(BuildContext, T, Widget?) builder;
146 changes: 144 additions & 2 deletions test/views/after_auth_screens/chat/select_contact_test.dart
Original file line number Diff line number Diff line change
@@ -2,20 +2,27 @@ import 'package:flutter/material.dart';
import 'package:flutter_localizations/flutter_localizations.dart';
import 'package:flutter_test/flutter_test.dart';
import 'package:mockito/mockito.dart';
import 'package:provider/provider.dart';
import 'package:talawa/constants/custom_theme.dart';
import 'package:talawa/models/user/user_info.dart';
import 'package:talawa/router.dart' as router;
import 'package:talawa/services/navigation_service.dart';
import 'package:talawa/services/size_config.dart';
import 'package:talawa/utils/app_localization.dart';
import 'package:talawa/view_model/after_auth_view_models/chat_view_models/select_contact_view_model.dart';
import 'package:talawa/view_model/lang_view_model.dart';
import 'package:talawa/view_model/theme_view_model.dart';
import 'package:talawa/views/after_auth_screens/chat/chat_list_screen.dart';
import 'package:talawa/views/after_auth_screens/chat/select_contact.dart';
import 'package:talawa/views/base_view.dart';
import 'package:talawa/main.dart';

import '../../../helpers/test_helpers.dart';
import '../../../helpers/test_locator.dart';

class MockSelectContactViewModel extends Mock
implements SelectContactViewModel {}

Widget createApp() {
return BaseView<AppLanguage>(
onModelReady: (model) => model.initialize(),
@@ -35,6 +42,25 @@ Widget createApp() {
);
}

Widget createTextSelectContact() {
return BaseView<AppLanguage>(
onModelReady: (model) => model.initialize(),
builder: (context, langModel, child) {
return MaterialApp(
locale: const Locale('en'),
localizationsDelegates: [
const AppLocalizationsDelegate(isTest: true),
GlobalMaterialLocalizations.delegate,
GlobalWidgetsLocalizations.delegate,
],
home: const SelectContact(),
navigatorKey: locator<NavigationService>().navigatorKey,
onGenerateRoute: router.generateRoute,
);
},
);
}

Widget createChatListScreen() {
return BaseView<AppLanguage>(
onModelReady: (model) => model.initialize(),
@@ -68,22 +94,41 @@ Future<void> showSelectContactScreenByChatPage(WidgetTester tester) async {
await tester.pumpAndSettle();
}

Future<void> showSelectContactText(WidgetTester tester) async {
await tester.pumpWidget(createTextSelectContact());
await tester.pump();
await tester.tap(find.text('Select Contacts'));
await tester.pumpAndSettle();
}

void main() {
SizeConfig().test();
// testSetupLocator();
registerServices();
registerViewModels();
final model = SelectContactViewModel();
model.initialise();
final User user1 = User(id: "fakeUser1");
final User user2 = User(id: "fakeUser2");
final User user1 = User(id: "fakeUser1", firstName: "John");
final User user2 = User(id: "fakeUser2", firstName: "Jane");
final List<User> users = [user1, user2];
late MockSelectContactViewModel mockViewModel;

setUp(() {
mockViewModel = MockSelectContactViewModel();
});

when(organizationService.getOrgMembersList("XYZ"))
.thenAnswer((realInvocation) async {
return users;
});

// when(() => organizationService.getOrgMembersList("XYZ")).thenAnswer(
// (_) async {
// await Future.delayed(const Duration(seconds: 2));
// return users;
// },
// );

testWidgets('Check if Select Contacts page shows up', (tester) async {
await tester.pumpWidget(createApp());
await tester.pump();
@@ -106,4 +151,101 @@ void main() {

expect(find.byType(Scaffold), findsOneWidget);
});

testWidgets('Select Contacts text is displayed', (WidgetTester tester) async {
await tester.pumpWidget(createApp());
await tester.pump();
expect(find.byType(Scaffold), findsOneWidget);

await showSelectContactScreenByChatPage(tester);
expect(find.text('Select Contacts'), findsOneWidget);
});

// testWidgets('renders app bar title correctly', (WidgetTester tester) async {
// // when(viewModel.orgMembersList).thenReturn(<User>[
// // User(firstName: 'John', id: '1', image: 'avatar.png'),
// // ]);
// await tester.pumpWidget(MaterialApp(home: SelectContact()));

// final titleFinder = find.text('Select Contacts');
// expect(titleFinder, findsOneWidget);
// });

testWidgets('Displays app bar correctly', (WidgetTester tester) async {
// when(viewModel.orgMembersList).thenReturn(<User>[
// User(firstName: 'John', id: '1', image: 'avatar.png'),
// ]);
await tester.pumpWidget(MaterialApp(home: SelectContact()));

final appBar = find.byType(AppBar);
expect(appBar, findsOneWidget);
});

// testWidgets('renders list tiles correctly', (WidgetTester tester) async {
// // when(viewModel.orgMembersList).thenReturn(<>[
// // User(firstName: 'John', id: '1', image: 'avatar.png'),
// // User(firstName: 'Jane', id: '2', image: 'avatar.png'),
// // ]);

// await tester.pumpWidget(MaterialApp(home: SelectContact()));

// final firstTileFinder = find.text('John');
// expect(firstTileFinder, findsOneWidget);

// final secondTileFinder = find.text('Jane');
// expect(secondTileFinder, findsOneWidget);

// final avatarFinder = find.byType(CircleAvatar);
// expect(avatarFinder, findsNWidgets(2));
// });

// testWidgets(
// 'should call initialise and getCurrentOrgUsersList on model ready',
// (WidgetTester tester) async {
// await tester.pumpWidget(
// MaterialApp(
// home: BaseView<SelectContactViewModel>(
// onModelReady: (model) {
// model.initialise();
// model.getCurrentOrgUsersList();
// mockViewModel;
// },
// //viewModel: mockViewModel,
// builder: (context, model, child) => SelectContact(),
// ),
// ),
// );

// verify(mockViewModel.initialise()).called(1);
// verify(mockViewModel.getCurrentOrgUsersList()).called(1);
// });

// testWidgets('should display a list of users', (WidgetTester tester) async {
// final users = [
// User(id: '1', firstName: 'John', image: 'image1'),
// User(id: '2', firstName: 'Jane', image: 'image2'),
// ];
// when(organizationService.getOrgMembersList("XYZ"))
// .thenAnswer((realInvocation) async {
// return users;
// });
// await tester.pumpWidget(createApp());
// await tester.pump();
// expect(find.byType(Scaffold), findsOneWidget);

// await showSelectContactScreenByChatPage(tester);
// expect(find.text('Select Contacts'), findsOneWidget);

// await tester.pumpWidget(
// MaterialApp(
// home: SelectContact(),
// ),
// );

// final user1 = find.text("John");
// final user2 = find.text("Jane");

// expect(user1, findsOneWidget);
// expect(user2, findsOneWidget);
// });
}
Binary file added test_img.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.