-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: use more detailed AI Summary for meetings #10501
chore: use more detailed AI Summary for meetings #10501
Conversation
@@ -0,0 +1,134 @@ | |||
import getKysely from '../../../postgres/getKysely' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code comes from the previous generateMeetingSummary
file
import canAccessAI from './canAccessAI' | ||
import {transformRetroToAIFormat} from './transformRetroToAIFormat' | ||
|
||
export const generateRetroSummary = async ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 I think the name is misleading. I would assume this function does just generate a summary for a meeting and returns it. Instead it updates the table.
I would prefer if we'd change it to updateRetroSummary
and also remove the return type, so it's less likely to be used wrongly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like updateRetroSummary
suggests it already exists and we're updating it, but we're creating a new summary here.
Maybe addRetroSummary
instead of generateRetroSummary
? I like that generate
describes that this is where it's being created.
Fix #10049
This PR updates the way we generate AI Summaries in meetings to use the more the detailed approach used in generate insights.
Now, when ending a retro meeting, we'll generate the AI Summary by using the same logic that dumps the data to a yaml file.
We're also using the updated prompt which encourages the use of links.
To test
generateRetroSummaries