Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: consolidate organizations sorting logic #10680

Merged
merged 2 commits into from
Jan 16, 2025
Merged

fix: consolidate organizations sorting logic #10680

merged 2 commits into from
Jan 16, 2025

Conversation

tianrunhe
Copy link
Contributor

@tianrunhe tianrunhe commented Jan 15, 2025 •
edited
Loading

Description

Fixes #10075

Demo

Screenshot 2025-01-15 at 15 00 22

Final checklist

  • I checked the code review guidelines
  • I have added Metrics Representative as reviewer(s) if my PR invovles metrics/data/analytics related changes
  • I have performed a self-review of my code, the same way I'd do it for any other team member
  • I have tested all cases I listed in the testing scenarios and I haven't found any issues or regressions
  • Whenever I took a non-obvious choice I added a comment explaining why I did it this way
  • I added the label Skip Maintainer Review Indicating the PR only requires reviewer review and can be merged right after it's approved if the PR introduces only minor changes, does not contain any architectural changes or does not introduce any new patterns and I think one review is sufficient'
  • PR title is human readable and could be used in changelog

@tianrunhe tianrunhe linked an issue Jan 15, 2025 that may be closed by this pull request
Make Org order consistent in Organizations view and left dash nav #10075
Closed
@tianrunhe tianrunhe added the Skip Maintainer Review Indicating the PR only requires reviewer review and can be merged right after it's approved label Jan 15, 2025
@tianrunhe tianrunhe merged commit 3d9b6d2 into master Jan 16, 2025
7 checks passed
@tianrunhe tianrunhe deleted the feat/10075/orgViewOrgOrder branch January 16, 2025 02:05
@parabol-release-bot parabol-release-bot bot mentioned this pull request Jan 16, 2025
Merged
@github-actions github-actions bot mentioned this pull request Jan 16, 2025
Closed
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickoferrall nickoferrall nickoferrall approved these changes

Assignees
No one assigned
Labels
size/s Skip Maintainer Review Indicating the PR only requires reviewer review and can be merged right after it's approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make Org order consistent in Organizations view and left dash nav
2 participants
@tianrunhe @nickoferrall