This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
[PAN-2941] Refactor privacy acceptance tests #1864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iikirilov
changed the title
iikirilov
force-pushed
the
PAN-2941
branch
5 times, most recently
from
8190cae to
b420439
Compare
iikirilov
commented
Aug 28, 2019
...ests/src/test/java/tech/pegasys/pantheon/tests/web3j/privacy/PrivacyGroupAcceptanceTest.java
Show resolved
Hide resolved
iikirilov
force-pushed
the
PAN-2941
branch
2 times, most recently
from
148e308 to
e08b274
Compare
iikirilov
changed the title
...antheon/tests/acceptance/dsl/node/configuration/privacy/PrivacyNodeConfigurationBuilder.java
Outdated
Show resolved
Hide resolved
.../test/java/tech/pegasys/pantheon/tests/acceptance/dsl/privacy/PrivacyAcceptanceTestBase.java
Show resolved
Hide resolved
...e-tests/src/test/java/tech/pegasys/pantheon/tests/acceptance/dsl/privacy/PrivacyCluster.java
Show resolved
Hide resolved
...src/test/java/tech/pegasys/pantheon/tests/acceptance/dsl/privacy/account/PrivacyAccount.java
Show resolved
Hide resolved
.../java/tech/pegasys/pantheon/tests/acceptance/dsl/privacy/account/PrivacyAccountSupplier.java
Outdated
Show resolved
Hide resolved
...ys/pantheon/tests/acceptance/dsl/privacy/contract/DeployPrivateSmartContractTransaction.java
Outdated
Show resolved
Hide resolved
...pegasys/pantheon/tests/acceptance/dsl/privacy/contract/CallPrivateSmartContractFunction.java
Outdated
Show resolved
Hide resolved
...asys/pantheon/tests/acceptance/dsl/privacy/contract/PrivateLoadSmartContractTransaction.java
Outdated
Show resolved
Hide resolved
.../pantheon/tests/acceptance/dsl/privacy/transaction/GetAllPrivacyMarkerTransactionHashes.java
Show resolved
Hide resolved
...asys/pantheon/ethereum/jsonrpc/internal/privacy/methods/priv/PrivCreatePrivacyGroupTest.java
Outdated
Show resolved
Hide resolved
rain-on
reviewed
Sep 2, 2019
...ptance-tests/src/test/java/tech/pegasys/pantheon/tests/acceptance/dsl/node/PantheonNode.java
Outdated
Show resolved
Hide resolved
...gasys/pantheon/tests/acceptance/dsl/node/configuration/PantheonNodeConfigurationBuilder.java
Show resolved
Hide resolved
...ys/pantheon/tests/acceptance/dsl/node/configuration/genesis/GenesisConfigurationFactory.java
Show resolved
Hide resolved
...gasys/pantheon/tests/acceptance/dsl/node/configuration/privacy/PrivacyNodeConfiguration.java
Outdated
Show resolved
Hide resolved
...ech/pegasys/pantheon/tests/acceptance/dsl/node/configuration/privacy/PrivacyNodeFactory.java
Outdated
Show resolved
Hide resolved
...ntheon/tests/acceptance/dsl/privacy/condition/ExpectValidPrivateContractDeployedReceipt.java
Show resolved
Hide resolved
...ntheon/tests/acceptance/dsl/privacy/condition/ExpectValidPrivateContractDeployedReceipt.java
Show resolved
Hide resolved
...va/tech/pegasys/pantheon/tests/acceptance/dsl/privacy/condition/PrivateContractVerifier.java
Show resolved
Hide resolved
...pegasys/pantheon/tests/acceptance/dsl/privacy/contract/CallPrivateSmartContractFunction.java
Show resolved
Hide resolved
...m/core/src/main/java/tech/pegasys/pantheon/ethereum/privacy/PrivateTransactionValidator.java
Outdated
Show resolved
Hide resolved
iikirilov
force-pushed
the
PAN-2941
branch
2 times, most recently
from
bbfea85 to
4d7fa95
Compare
rain-on
reviewed
Sep 3, 2019
...ech/pegasys/pantheon/tests/acceptance/dsl/node/configuration/privacy/PrivacyNodeFactory.java
Outdated
Show resolved
Hide resolved
...src/test/java/tech/pegasys/pantheon/tests/acceptance/dsl/privacy/account/PrivacyAccount.java
Outdated
Show resolved
Hide resolved
...tech/pegasys/pantheon/tests/acceptance/dsl/privacy/condition/PrivateTransactionVerifier.java
Outdated
Show resolved
Hide resolved
.../pantheon/tests/acceptance/dsl/privacy/transaction/GetAllPrivacyMarkerTransactionHashes.java
Show resolved
Hide resolved
* also moves privacy jsonrpc package to higher level for better encapsulation of privacy code * spotless
* update web3j 4.4.0 + use pantheon module in favour of core * remove custom eea/privacy rpc calls -> use web3j instead * overhaul the conditions -> web3j does the polling for receipts for us * re-define a PrivacyNode - it is an object that holds a PantheonNode and an OrionTestHarness * do not start OrionTestHarness prematurely - calling PrivacyNode.start() will start an Orion node followed by it's accompanying Pantheon node * stop and close resources properly -> clean-up removes the created temporary directories correctly
…puriousDragon milestone
rain-on
approved these changes
Sep 3, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Restructures the Privacy acceptance tests to follow the dsl and structure of Mainnet acceptance tests.
Updates to web3j 4.5.0
Renames some configuration classes in the acceptance to more suitable name - mainly
PantheonFactoryConfiguration->PantheonNodeConfigurationand similar. Considering this is not a configuration for a factory, but rather for the node produced by the factory that is being used in tests. This removes some confusion.Updates EthSigner to 0.3.0
Fixes Ibft privacy tests - still in flight
N.B. There is 1 known failing test
Fixed Issue(s)
PAN-2941PAN-2643