Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Compiler] Add Catalyst jacobian and grad methods #4709

Merged
merged 13 commits into from
Nov 7, 2023

Conversation

maliasadi
Copy link
Member

Context:
This PR adds support for QJIT compatible qml.jacobian and qml.grad. Please see ADR 74 for implementation details.

[sc-46406]

@github-actions
Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (9c593fe) 99.57% compared to head (498f0e1) 99.55%.
Report is 2 commits behind head on maa/integrate-catalyst-2.

Additional details and impacted files
@@                     Coverage Diff                      @@
##           maa/integrate-catalyst-2    #4709      +/-   ##
============================================================
- Coverage                     99.57%   99.55%   -0.02%     
============================================================
  Files                           383      382       -1     
  Lines                         34046    33919     -127     
============================================================
- Hits                          33901    33768     -133     
- Misses                          145      151       +6     
Files Coverage Δ
pennylane/_grad.py 90.12% <57.89%> (-9.88%) ⬇️

... and 34 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pennylane/_grad.py Outdated Show resolved Hide resolved
pennylane/_grad.py Outdated Show resolved Hide resolved
@maliasadi maliasadi requested review from josh146 and dime10 October 26, 2023 14:38
Copy link
Member

@josh146 josh146 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my end @maliasadi! Just minor updates

pennylane/_grad.py Outdated Show resolved Hide resolved
pennylane/_grad.py Outdated Show resolved Hide resolved
pennylane/_grad.py Outdated Show resolved Hide resolved
pennylane/_grad.py Outdated Show resolved Hide resolved
pennylane/_grad.py Outdated Show resolved Hide resolved
pennylane/_grad.py Outdated Show resolved Hide resolved
pennylane/_grad.py Outdated Show resolved Hide resolved
pennylane/_grad.py Outdated Show resolved Hide resolved
pennylane/_grad.py Outdated Show resolved Hide resolved
pennylane/_grad.py Show resolved Hide resolved
maliasadi and others added 2 commits October 26, 2023 15:08
@maliasadi maliasadi requested a review from rmoyard October 27, 2023 13:31
Copy link
Contributor

@rmoyard rmoyard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks it looks good to me 💯

@maliasadi maliasadi merged commit 3cc2c09 into maa/integrate-catalyst-2 Nov 7, 2023
@maliasadi maliasadi deleted the maa/plc/grad branch November 7, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants