-
Notifications
You must be signed in to change notification settings - Fork 624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update drawer catalyst and add draw_mpl #4815
Conversation
…e. Add the AvailableCompilers dataclass and update tests
Co-authored-by: Josh Izaac <[email protected]>
**Context:** Catalyst frontend is being integrated into PL **Description of the Change:** Attempt to add Catalyst to intersphinx to help with cross referencing of docs **Benefits:** **Possible Drawbacks:** [sc-46399] --------- Co-authored-by: Ali Asadi <[email protected]>
Co-authored-by: David Ittah <[email protected]>
Co-authored-by: Josh Izaac <[email protected]>
From the doc page of [pkg_resources](https://setuptools.pypa.io/en/latest/pkg_resources.html): > Use of pkg_resources is deprecated in favor of [importlib.resources](https://docs.python.org/3.11/library/importlib.resources.html#module-importlib.resources), [importlib.metadata](https://docs.python.org/3.11/library/importlib.metadata.html#module-importlib.metadata) and their backports ([importlib_resources](https://pypi.org/project/importlib_resources), [importlib_metadata](https://pypi.org/project/importlib_metadata)). Some useful APIs are also provided by [packaging](https://pypi.org/project/packaging) (e.g. requirements and version parsing). Users should refrain from new usage of pkg_resources and should work to port to importlib-based solutions. PR #4783 updates all occurrences of `pkg_resources` with `importlib.metadata` across the entire PL. This PR, however, addresses this replacement in the compiler driver, which has not yet been merged into PL. [sc-46399]
Context: This PR adds support for QJIT compatible `qml.jacobian` and `qml.grad`. Please see ADR 74 for implementation details. [sc-46406] --------- Co-authored-by: Josh Izaac <[email protected]>
Hello. You may have forgotten to update the changelog!
|
[sc-48842] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 non-blocking comments, but I checked out the branch and drew the tests and they look good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rmoyard! 🎉
Co-authored-by: Ali Asadi <[email protected]>
Co-authored-by: Matthew Silverman <[email protected]>
Co-authored-by: Ali Asadi <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4815 +/- ##
==========================================
- Coverage 99.65% 99.64% -0.02%
==========================================
Files 387 387
Lines 35018 34756 -262
==========================================
- Hits 34898 34633 -265
- Misses 120 123 +3 ☔ View full report in Codecov by Sentry. |
LGTM 🎉 |
**Description of the Change:** - Update how to check if Catalyst available - Add draw mpl --------- Co-authored-by: Ali Asadi <[email protected]> Co-authored-by: Josh Izaac <[email protected]> Co-authored-by: David Ittah <[email protected]> Co-authored-by: Matthew Silverman <[email protected]>
Description of the Change: