Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use CI=1 for tidb make command #2167

Merged
merged 2 commits into from
Jun 15, 2023
Merged

fix: use CI=1 for tidb make command #2167

merged 2 commits into from
Jun 15, 2023

Conversation

xhebox
Copy link
Contributor

@xhebox xhebox commented Jun 15, 2023

No description provided.

@ti-chi-bot ti-chi-bot bot requested review from jayl1e and purelind June 15, 2023 05:09
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 15, 2023

Hi @xhebox. Thanks for your PR.

I'm waiting for a PingCAP-QE member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: xhe <[email protected]>
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 15, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-06-15 05:16:21.373610155 +0000 UTC m=+235577.788214219: ☑️ agreed by hawkingrei.

Copy link
Collaborator

@purelind purelind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, purelind

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jun 15, 2023
@ti-chi-bot ti-chi-bot bot merged commit d1c63ce into PingCAP-QE:main Jun 15, 2023
@xhebox xhebox mentioned this pull request Jun 15, 2023
12 tasks
purelind added a commit that referenced this pull request Aug 4, 2023
ti-chi-bot bot pushed a commit that referenced this pull request Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants