Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: make CI=0 default #44694

Merged
merged 1 commit into from
Jun 15, 2023
Merged

*: make CI=0 default #44694

merged 1 commit into from
Jun 15, 2023

Conversation

xhebox
Copy link
Contributor

@xhebox xhebox commented Jun 15, 2023

What problem does this PR solve?

Issue Number: close None

Problem Summary: Check PingCAP-QE/ci#2167, no logger need make CI=0.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 15, 2023
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jun 15, 2023
@xhebox xhebox requested a review from ywqzzy June 15, 2023 07:06
@xhebox xhebox added the skip-issue-check Indicates that a PR no need to check linked issue. label Jun 15, 2023
@xhebox xhebox requested a review from CbcWestwolf June 15, 2023 09:23
@hawkingrei hawkingrei requested a review from YangKeao June 15, 2023 09:58
Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, YangKeao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [YangKeao,hawkingrei]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 15, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 15, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-06-15 06:56:39.777483514 +0000 UTC m=+241596.192087592: ☑️ agreed by hawkingrei.
  • 2023-06-15 10:16:15.918830871 +0000 UTC m=+253572.333434950: ☑️ agreed by YangKeao.

@hawkingrei
Copy link
Member

/test tiprow_test

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 15, 2023

@hawkingrei: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test build
  • /test canary-scan-security
  • /test check-dev
  • /test check-dev2
  • /test mysql-test
  • /test pingcap/tidb/canary_ghpr_unit_test
  • /test pull-integration-mysql-test
  • /test unit-test

Use /test all to run the following jobs that were automatically triggered:

  • pingcap/tidb/ghpr_build
  • pingcap/tidb/ghpr_check
  • pingcap/tidb/ghpr_check2
  • pingcap/tidb/ghpr_mysql_test
  • pingcap/tidb/ghpr_unit_test

In response to this:

/test tiprow_test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot merged commit 1077c72 into pingcap:master Jun 15, 2023
@xhebox xhebox deleted the fix_3 branch April 7, 2024 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. skip-issue-check Indicates that a PR no need to check linked issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants