Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converter exits with -1 but exit code 0 expected, because conversion works without error #1851

Closed
pclbel opened this issue Apr 4, 2017 · 2 comments

Comments

@pclbel
Copy link

pclbel commented Apr 4, 2017

⚠️ This is a issue tracker, please use our mailing list for questions: www.pcl-users.org. ⚠️

Your Environment

PCL 1.8.0

Expected Behavior

Expected that the converter ends with exit code 0, but instead exits with -1

Current Behavior

converter exits with -1 in case of successfull conversion

Possible Solution

line 273 if condition wrong, has to be negiated
see https://github.com/PointCloudLibrary/pcl/blob/master/io/tools/converter.cpp#L273

Code to Reproduce

convert a ply to a binary pcd without faces

Context

converting a ply to a binary pcd without faces

@taketwo
Copy link
Member

taketwo commented Apr 4, 2017

Thanks for bringing this up. Could you please add a link to the relevant file/line?

@maflcko
Copy link
Contributor

maflcko commented Apr 4, 2017

Also, you can simply submit a pull request by opening the file in the GitHub web view and pressing the Edit icon in the top right corner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants