Fixes incorrect return value of pcl converter #1903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
BTW any idea why your topic branch ended up in the main PCL repo? |
|
I edited the file on GitHub and submitted the PR on the spot. I though the process was exactly the same... |
|
I'm confused... What exactly is the "topic branch"? I did manually add topics "pcl, computer-visio, etc..." to the repo, but I thought that's a github specific search related functionality. This commit is innocent. |
|
I understand what you mean now! I made the edit on pcl's GitHub page, instead than doing on mine... Apologies. I'll delete it right away. I got confused with the word "topic". |
|
Sorry didn't mean to confuse you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1851. Credits to @pclbel .