Fix for issue #1189 --->PFH buffer, adds to key list even is key was found #1243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uest that only fixes 1189 Resolved conflict induced by automatic git revert Revert "fixed wrong erasing order on feature_map_ in PFHEstimation" This reverts commit bbec109. Conflicts: features/include/pcl/features/impl/pfh.hpp
|
👍 This LGTM. Can you squash it please and then we should be good to go. |
SergioRAgostinho
added
needs: author reply
SergioRAgostinho
pushed a commit
to SergioRAgostinho/pcl
that referenced
this pull request
Aug 26, 2016
SergioRAgostinho
pushed a commit
to SergioRAgostinho/pcl
that referenced
this pull request
Aug 26, 2016
SergioRAgostinho
removed
the
needs: author reply
SergioRAgostinho
pushed a commit
to SergioRAgostinho/pcl
that referenced
this pull request
Aug 26, 2016
SergioRAgostinho
pushed a commit
to SergioRAgostinho/pcl
that referenced
this pull request
Aug 27, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #1189; replacement of PR #1191 but only fixes a single issue