Prevent addition of duplicate keys in PFHEstimation buffer #1701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -133,7 +140,7 @@ pcl::PFHEstimation<PointInT, PointNT, PointOutT>::computePointPFHSignature ( | |||
| } | |||
| pfh_histogram[h_index] += hist_incr; | |||
|
|
|||
| if (use_cache_) | |||
| if ( use_cache_ && !key_found ) | |||
There was a problem hiding this comment.
Extra space before use_cache_
SergioRAgostinho
force-pushed
the
pfh-red-key
branch
from
06d84ea to
1b5ef7a
Compare
| @@ -133,7 +140,7 @@ pcl::PFHEstimation<PointInT, PointNT, PointOutT>::computePointPFHSignature ( | |||
| } | |||
| pfh_histogram[h_index] += hist_incr; | |||
|
|
|||
| if (use_cache_) | |||
| if (use_cache_ && !key_found ) | |||
There was a problem hiding this comment.
HAHAHA.... fml ^^ just a sec.
SergioRAgostinho
force-pushed
the
pfh-red-key
branch
from
1b5ef7a to
6ff1085
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
find redundant adding of identical keys to the key list in PFHEstimation buffer
Closes #1243. Fixes #1189. Credits to @strothmw who seems inactive to apply the changes. Managed to preserve his authorship.