Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove VTK legacy functions #2159

Closed
wants to merge 1 commit into from

Conversation

jasjuang
Copy link
Contributor

Recently VTK removes some legacy functions that causes PCL to stop compiling.

Kitware/VTK@fc2ac65

The fix is applied according to the suggestion of the VTK devs.

I tested and it compiles and runs without a problem on Ubuntu 16.04 latest PCL.

@taketwo
Copy link
Member

taketwo commented Dec 17, 2017

#2112 already takes care of this, however there the function calls are not removed, instead conditionally disabled with #if VTK_RENDERING_BACKEND_OPENGL_VERSION < 2. Do you think it is wrong? Also, what the "suggestion of the VTK devs" that you are referring to?

@jasjuang
Copy link
Contributor Author

@taketwo "suggestion of the VTK devs" is referring to the comments mentioned in the very bottom of Kitware/VTK@fc2ac65

You are actually right, #2112 does take care of it and using #if VTK_RENDERING_BACKEND_OPENGL_VERSION < 2 might actually provide additional backwards compatibility on old old VTK.

What is the status of #2112? If you plan to merge #2112 soon feel free to close this PR. However if it's going to take some time I can push the #if VTK_RENDERING_BACKEND_OPENGL_VERSION < 2 change to get PCL to compile again.

@taketwo
Copy link
Member

taketwo commented Dec 18, 2017

The author of #2112 did not reply for a while, so I pushed an additional commit addressing remaining review issues. Once the CI pipelines are finished I'll merge.

@taketwo taketwo closed this Dec 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants