This repository has been archived by the owner on Nov 4, 2021. It is now read-only.
nicer handling of insert distinct id failure #527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 13, 2021
mariusandra
approved these changes
Aug 16, 2021
yakkomajuri
added a commit
that referenced
this pull request
Sep 14, 2021
This reverts commit 1991794.
yakkomajuri
added a commit
that referenced
this pull request
Sep 14, 2021
fuziontech
pushed a commit
to PostHog/posthog
that referenced
this pull request
Oct 12, 2021
fuziontech
pushed a commit
to PostHog/posthog
that referenced
this pull request
Oct 12, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
I did some digging and turns out Postgres errors like 20-40 times per minute trying to insert a distinct ID that already exists. More context on #526
The plugin server handles this properly yet it swallows the errors, while Postgres creates a bit of logspam for what is an expected error for our system. This is similar to #523
Ultimately, this means that on Cloud we're doing tens of thousands of unnecessary queries a day just for distinct ID inserts, but I think any potential solution at this stage might just be over-engineering and would still be prone to race conditons, even if it shortens the window for them to happen.
Anyway, so this just silences unnecessary Postgres errors while making sure the errors we do care about are actually captured in Sentry.
Checklist