feat(experiments): Create a dashboard in one click #27503
Conversation
|
Size Change: +239 B (+0.02%) Total Size: 1.13 MB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Nice feature!
I experienced two issues when running this locally:
- the toast did not show
- no metrics were added to the dashboard
Could be a local issue on my end, but I didn't see any obvious reasons for that, and no errors in console or log 🤔
Screen.Recording.2025-01-15.at.12.37.26.mov
@andehen Hm, it seems like the code didn't execute fully. Did it reproduce multiple times? Can you look at your network requests and see what's happening there? Because there's no intermediate UX while the dashboard is being created, I tried showing a "Creating experiment dashboard..." toast but didn't love it. |
Co-authored-by: Anders <[email protected]>
| if (metrics.length === 0) { | ||
| return | ||
| } |
There was a problem hiding this comment.
@andehen Hm, it seems like the code didn't execute fully. Did it reproduce multiple times? Can you look at your network requests and see what's happening there?
Here is the bug. It only works if you have both a primary and a secondary metric defined here due to the early return
There was a problem hiding this comment.
The one I tested with had only a primary metric. Adding a secondary metric and it works.
There was a problem hiding this comment.
Ah, good catch! That should be a continue but we can remove it entirely 6129425
Ah, yeah. Fixed with bb099f8 |
|
Very cool! |
See #26934
Changes
A basic implementation that lets a customer create a dashboard for an experiment in one-click:
CleanShot.2025-01-14.at.06.10.24.mp4
I deliberately didn't store the dashboard id in the database to avoid schema modifications until we have a good sense of how this feature should work. We can continue to iterate based on usage and feedback.
How did you test this code?
I created many dashboards from an experiment.