Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(experiments): Create a dashboard in one click #27503

Merged
merged 6 commits into from
Jan 15, 2025
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'master' into experiments/create-dashboard
danielbachhuber committed Jan 14, 2025
commit 70784685b519f5eb50a2ea895beedc509ea0e887
14 changes: 0 additions & 14 deletions frontend/src/scenes/experiments/ExperimentView/components.tsx
Original file line number Diff line number Diff line change
@@ -312,20 +312,6 @@ export function PageHeaderCustom(): JSX.Element {
>
Create dashboard
</LemonButton>
<LemonButton
onClick={() => loadMetricResults(true)}
fullWidth
data-attr="refresh-experiment"
>
Refresh primary metrics
</LemonButton>
<LemonButton
onClick={() => loadSecondaryMetricResults(true)}
fullWidth
data-attr="refresh-secondary-metrics"
>
Refresh secondary metrics
</LemonButton>
</>
}
/>

Unchanged files with check annotations Beta

})
// TODO: this test works locally, just not in CI
it.skip('can delete dashboard and delete the insights', () => {

Check warning on line 25 in cypress/e2e/dashboard-deletion.cy.ts

GitHub Actions / Code quality checks

Disabled test
cy.visit(urls.savedInsights()) // get insights list into turbo mode
cy.clickNavMenu('dashboards')
cy.get('[data-attr=paths-viz]').should('exist')
})
it.skip('can save paths', () => {

Check warning on line 20 in cypress/e2e/paths.cy.ts

GitHub Actions / Code quality checks

Disabled test
cy.get('[data-attr="insight-edit-button"]').should('not.exist')
cy.get('[data-attr="insight-save-button"]').click()
cy.get('[data-attr="insight-edit-button"]').should('exist')
useEffect(() => {
loadCurrentTeamSuccess(null)
router.actions.push(urls.projectHomepage())
}, [])

Check warning on line 77 in frontend/src/layout/ErrorProjectUnavailable.stories.tsx

GitHub Actions / Code quality checks

React Hook useEffect has a missing dependency: 'loadCurrentTeamSuccess'. Either include it or remove the dependency array
return <App />
}
export const NoSelectableProjects = (): JSX.Element => {
useEffect(() => {
loadCurrentTeamSuccess(null)
router.actions.push(urls.projectHomepage())
}, [])

Check warning on line 109 in frontend/src/layout/ErrorProjectUnavailable.stories.tsx

GitHub Actions / Code quality checks

React Hook useEffect has a missing dependency: 'loadCurrentTeamSuccess'. Either include it or remove the dependency array
return <App />
}
}
options.push(<>reach out to your administrator for access</>)
setOptions(options)
}, [])

Check warning on line 32 in frontend/src/layout/ErrorProjectUnavailable.tsx

GitHub Actions / Code quality checks

React Hook useEffect has missing dependencies: 'projectCreationForbiddenReason' and 'user.organization?.teams'. Either include them or remove the dependency array
const listOptions = (): JSX.Element => (
<>
const { earlyAccessFeatures, rawEarlyAccessFeaturesLoading } = useValues(featurePreviewsLogic)
const { loadEarlyAccessFeatures } = useActions(featurePreviewsLogic)
useLayoutEffect(() => loadEarlyAccessFeatures(), [])

Check warning on line 13 in frontend/src/layout/FeaturePreviews/FeaturePreviews.tsx

GitHub Actions / Code quality checks

React Hook useLayoutEffect has a missing dependency: 'loadEarlyAccessFeatures'. Either include it or remove the dependency array
return (
<div
useEffect(() => {
refine(type)
}, [])

Check warning on line 116 in frontend/src/layout/navigation-3000/components/AlgoliaSearch.tsx

GitHub Actions / Code quality checks

React Hook useEffect has missing dependencies: 'refine' and 'type'. Either include them or remove the dependency array
return (
<button className="p-0 cursor-pointer bg-bg-light" onClick={handleClick}>
})
refine(activeTag)
}
}, [activeTag])

Check warning on line 233 in frontend/src/layout/navigation-3000/components/AlgoliaSearch.tsx

GitHub Actions / Code quality checks

React Hook useEffect has missing dependencies: 'items' and 'refine'. Either include them or remove the dependency array
useEffect(() => {
const handleClick = (e: any): void => {
const { activeNavbarItem } = useValues(navigation3000Logic)
useEffect(() => {
showSidebar(Scene.Dashboards) // Active this sidebar
}, [])

Check warning on line 47 in frontend/src/layout/navigation-3000/components/Sidebar.stories.tsx

GitHub Actions / Code quality checks

React Hook useEffect has a missing dependency: 'showSidebar'. Either include it or remove the dependency array
return (
<div className="flex">
const { activeNavbarItem } = useValues(navigation3000Logic)
useEffect(() => {
showSidebar(Scene.FeatureFlags) // Activate this sidebar
}, [])

Check warning on line 66 in frontend/src/layout/navigation-3000/components/Sidebar.stories.tsx

GitHub Actions / Code quality checks

React Hook useEffect has a missing dependency: 'showSidebar'. Either include it or remove the dependency array
return (
<div className="flex">
You are viewing a condensed version of this merge commit. You can view the full changes here.