Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve funnel dashboards #5253

Merged
merged 1 commit into from
Jul 21, 2021
Merged

Improve funnel dashboards #5253

merged 1 commit into from
Jul 21, 2021

Conversation

mariusandra
Copy link
Collaborator

Changes

Before:

After:
Screenshot 2021-07-21 at 16 59 24

Checklist

  • All querysets/queries filter by Organization, by Team, and by User
  • Django backend tests
  • Jest frontend tests
  • Cypress end-to-end tests
  • Migrations are safe to run at scale (e.g. PostHog Cloud) – present proof if not obvious
  • New/changed UI is decent on smartphones (viewport width around 360px)

@mariusandra mariusandra requested a review from alexkim205 July 21, 2021 15:08
@timgl timgl temporarily deployed to posthog-pr-5253 July 21, 2021 15:10 Inactive
@mariusandra mariusandra mentioned this pull request Jul 21, 2021
Closed
paolodamico
paolodamico approved these changes Jul 21, 2021
View reviewed changes
Copy link
Contributor

@paolodamico paolodamico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@paolodamico paolodamico merged commit a414250 into master Jul 21, 2021
@paolodamico paolodamico deleted the funnel-fixes-part-three branch July 21, 2021 15:28
@alexkim205 alexkim205 restored the funnel-fixes-part-three branch July 21, 2021 16:00
@alexkim205 alexkim205 mentioned this pull request Jul 21, 2021
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paolodamico paolodamico paolodamico approved these changes

@alexkim205 alexkim205 Awaiting requested review from alexkim205

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mariusandra @paolodamico @timgl