Funnels functional bugs

[paolodamico]

Fairly blocking functional bugs on funnels.

1. This state comes in unexpectedly when building funnels. Initially reported as a problem with having no breakdown values that match a query, you can see in this recording that this funnel should have results, $pageview is the first event with no filters, there's always a Pageview. Further, if you refresh, the funnel renders.

2. There's some strange bug where the bars don't get properly rendered.

3. Time to convert doesn’t “height: 100%”
   

4. The historical conversion should be a line chart

CC @mariusandra

[mariusandra]

I think 1 and 2 are fixed with #5248

[mariusandra]

Point 4 is also fixed in that PR, though it adds a bit of a scrollbar.

[mariusandra]

5. Clicking the modal to open people doesn't work on dashboards. The error is silently swallowed, so not a blocker though. Not sure if Handle persons modal navigation better #5236 would fix or not.

[mariusandra]

6. "All steps" are merged together here:
   

Individual steps are fine:

[paolodamico]

7. Conversion trends does not render on Postgres

[alexkim205]

1. Conversion trends does not render on Postgres

This is intentional as conversion trends is a CH only feature. Do you suggest we have a more user friendly omission?

3. Time to convert doesn’t “height: 100%”

I'll take point on this!

[EDsCODE]

8. funnel steps left to right can't handle more than 4 steps
9. when clicking persons modal load more, it always says "Showing 99 of X" no matter how big X is. I also think it only shows the top 99 even if you load up more than 99

[mariusandra]

Fix for 3 and 4 here: #5253

[paolodamico]

10. Can't reproduce yet but 100% funnel chart not taking up 100% height #5251 is not rendering the 100% funnel bars properly

[paolodamico]

Started crossing out issues that have been fixed. Issue no. 3 is still happening but now differently. Let me get CH running to fix.

[EDsCODE]

11. clicking on a breakdown segment for funnel step should only return the subset not all the persons for that step. (seems like a backend issue)

[neilkakkar]

11. clicking on a breakdown segment for funnel step should only return the subset not all the persons for that step. (seems like a backend issue)

Just checked, not a backend issue. We aren't sending the funnel_step_breakdown parameter to the Persons query, which only returns the persons for that breakdown. (The value for this is the breakdown value returned by the API on the funnel query)

[alexkim205]

@paolodamico

Started crossing out issues that have been fixed. Issue no. 3 is still happening but now differently. Let me get CH running to fix.

3. This should :sparkjoy: - Fix funnels time to convert dashboard item height #5259

[alexkim205]

6. Seems like a backend bug where bin sizes aren't equal.

Example response (see last bin)

Only seems to be happening in all steps responses

[paolodamico]

Re @EDsCODE, can you elaborate? Can't seem to reproduce. Maybe the problem is that it's not obvious that you can scroll to the right?

8. funnel steps left to right can't handle more than 4 steps

[mariusandra]

Status update

Pending review:

• Time to convert doesn’t “height: 100%”: Fix funnels time to convert dashboard item height #5259
• "Showing 99 of X" no matter how big X is: Fix persons modal load more people #5271
• Fix z-index issue inside drawers: Fix Mix - z-index & multiple cohorts in breakdown #5270
• Fix breakdown filter multiple cohorts: Fix Mix - z-index & multiple cohorts in breakdown #5270
• Persist feature flags in the release: Add PERSISTED_FEATURE_FLAGS env #5273

Still to do:

• Persist the specific feature flags we want to: Enable filter and funnel feature flags #5282

Experience not started:

• Eric: "clicking on a breakdown segment for funnel step should only return the subset not all the persons for that step. (seems like a backend issue)" --> Neil: "Just checked, not a backend issue. We aren't sending the funnel_step_breakdown parameter to the Persons query" --> ... ?
• Clicking dashboard items won't open person modals: Do not allow persons modal opening on funnels dashboard item view #5286
  
• Automatically set default funnelVizType for queries like this (e.g. old saved insights). Without it currently the breakdown filter doesn't show up. Funnel default event #5280
• Dashboards change position randomly #5262 <-- oh god what's this now? 😨

Query blockers... or fixed?

• All steps are merged -> "Seems like a backend bug" --> what's the status? @alexkim205 @neilkakkar ? Resolve errors with time to convert bins #5283
• Fix the issue here where you need to turn off "filter out internal users" before the breakdown is applied. @neilkakkar ?

Bonus if we can get it in:

• Add FunnelStepTable #5233

Next release:

• Persons modal session recordings? #5216

[neilkakkar]

All steps are merged -> "Seems like a backend bug" --> what's the status? @alexkim205 @neilkakkar ?

Can you give me a link to an example where this still happens? Can't seem to reproduce.

---

Eric: "clicking on a breakdown segment for funnel step should only return the subset not all the persons for that step. (seems like a backend issue)" --> Neil: "Just checked, not a backend issue. We aren't sending the funnel_step_breakdown parameter to the Persons query" --> ... ?

Haven't done anything about this yet! If anyone else has the bandwidth, please feel free to pick up.

---

Fix the issue here where you need to turn off "filter out internal users" before the breakdown is applied. @neilkakkar ?

On this! Original issue seems to be fixed, but looks like there's a new one with breakdowns not working on actions.

[mariusandra]

A. Here's an example where all the funnel bins are still merged together.

B. I should be able to pick this up soon.

C. Great!

[neilkakkar]

Is this how the example above is supposed to look? 👀

[mariusandra]

@neilkakkar apologies, this is the broken example

I'm not sure if it's a backend or a frontend bug to be honest. Does this data look legit to you?

[neilkakkar]

The null in the end seems wrong, so looks like a backend issue to me as well. Looking 👀 .

[neilkakkar]

@neilkakkar apologies, this is the broken example

Ok, this one is looking good now, can you confirm as well please?

[mariusandra]

Much better, thank you! :)

[mariusandra]

Another summary.

Ready to merge:

• Enable filter and funnel feature flags #5282 (ultimately blocked behind All Users cohort in breakdown filter #5293, but could already be reviewed)
• Use flex-basis instead of percentage for funnel bar sizing #5269
• Trends breakdown table total sum bug #5285

Frontend todo:

• Eric: "clicking on a breakdown segment for funnel step should only return the subset not all the persons for that step. (seems like a backend issue)" --> Neil: "Just checked, not a backend issue. We aren't sending the funnel_step_breakdown parameter to the Persons query" --> ... ? Pass in funnel_step_breakdown param for funnels breakdown persons modal #5289
• Add "All Users" option into cohort breakdown All Users cohort in breakdown filter #5293

Backend todo:

• Breakdown on funnel fails to load #5211 / Breakdown person props naming bugs #5288

Bonus:

• Can we still get this in? Add FunnelStepTable #5233
• Bug that was there before: Dashboards change position randomly #5262
• Are there any more filters or dropdowns that could be converted to the new one? All property filters got converted, but there are other on-off dropdowns. The "event" selector under "events" is for sure one such case. We should list them and then convert to the taxonomic one.
• Even with the new taxonomic filter, the event & person properties are still loaded in the background. E.g. for usage under the "event stats" page... or in the "event name" filter under events. Can we not load them, even if in the background?

[mariusandra]

Last blocking things:

• Finish & Merge: Pass in funnel_step_breakdown param for funnels breakdown persons modal #5289
• Review & Merge: All Users cohort in breakdown filter #5293
• Fix bugs with Postgres & calculate button: Funnel calculation bug on Postgres / empty state #5298
  • PR - Fix various funnels empty state UX postgres #5304
• Time conversion histogram paint optimization #5265
• Remove breakdown table checkboxes Remove funnel step checkboxes, logic, and associated types #5300 (comment)
• Funnel histogram labels are often on top of each other Wrap d3 histogram labels #5301

[paolodamico]

Looks like this is actually done, so closing.