Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Funnel default event #5280

Merged
merged 5 commits into from
Jul 22, 2021
Merged

Funnel default event #5280

merged 5 commits into from
Jul 22, 2021

Conversation

mariusandra
Copy link
Collaborator

Changes

The default event to show ($pageview or $screen) was captured from the event definitions, once they all had loaded. We don't wait for those to load before showing the filters, so that caused problems. This moves the default event name selection into django before the frontend loads.

Before:
2021-07-22 14 37 51

After:
2021-07-22 14 36 53

Checklist

  • All querysets/queries filter by Organization, by Team, and by User
  • Django backend tests
  • Jest frontend tests
  • Cypress end-to-end tests
  • Migrations are safe to run at scale (e.g. PostHog Cloud) – present proof if not obvious
  • New/changed UI is decent on smartphones (viewport width around 360px)

@mariusandra mariusandra requested review from paolodamico and liyiy July 22, 2021 12:38
@timgl timgl temporarily deployed to posthog-pr-5280 July 22, 2021 12:40 Inactive
@timgl timgl temporarily deployed to posthog-pr-5280 July 22, 2021 14:25 Inactive
Copy link
Contributor

@paolodamico paolodamico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellent!

@mariusandra mariusandra enabled auto-merge (squash) July 22, 2021 14:36
@mariusandra mariusandra temporarily deployed to posthog-pr-5280 July 22, 2021 15:40 Inactive
@mariusandra mariusandra disabled auto-merge July 22, 2021 15:54
@mariusandra
Copy link
Collaborator Author

Two broken tests, both seem to be unrelated flakes (ee.clickhouse.views.test.test_clickhouse_action.TestActionPeople and .invitesMembers.js), thus merging.

@mariusandra mariusandra merged commit 19d9fcc into master Jul 22, 2021
@mariusandra mariusandra deleted the funnel-default-event branch July 22, 2021 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants