Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not allow persons modal opening on funnels dashboard item view #5286

Merged
merged 1 commit into from
Jul 22, 2021
Merged

Do not allow persons modal opening on funnels dashboard item view #5286

merged 1 commit into from
Jul 22, 2021

Conversation

liyiy
Copy link
Contributor

@liyiy liyiy commented Jul 22, 2021

Changes

Please describe.
If this affects the frontend, include screenshots.

Screen Shot 2021-07-22 at 11 06 48 AM

Checklist

  • All querysets/queries filter by Organization, by Team, and by User
  • Django backend tests
  • Jest frontend tests
  • Cypress end-to-end tests
  • Migrations are safe to run at scale (e.g. PostHog Cloud) – present proof if not obvious
  • New/changed UI is decent on smartphones (viewport width around 360px)

@liyiy liyiy requested a review from mariusandra July 22, 2021 15:09
@timgl timgl temporarily deployed to posthog-pr-5286 July 22, 2021 15:10 Inactive
@liyiy liyiy requested a review from paolodamico July 22, 2021 15:15
mariusandra
mariusandra approved these changes Jul 22, 2021
View reviewed changes
Copy link
Collaborator

@mariusandra mariusandra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mariusandra mariusandra enabled auto-merge (squash) July 22, 2021 15:16
@mariusandra mariusandra mentioned this pull request Jul 22, 2021
Closed
@mariusandra mariusandra merged commit bfb1a00 into master Jul 22, 2021
@mariusandra mariusandra deleted the no-dashboarditem-persons-modal branch July 22, 2021 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariusandra mariusandra mariusandra approved these changes

@paolodamico paolodamico Awaiting requested review from paolodamico

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@liyiy @mariusandra @timgl