Breakdown person props naming bugs

[EDsCODE]

Changes

Please describe.

• addresses some aspects of Breakdown on funnel fails to load #5211
• for breakdown person props, our filters were sharing param key names and overwriting one another
• the table name for the inner query was also incorrect
• added a test
  If this affects the frontend, include screenshots.

Checklist

• All querysets/queries filter by Organization, by Team, and by User
• Django backend tests
• Jest frontend tests
• Cypress end-to-end tests
• Migrations are safe to run at scale (e.g. PostHog Cloud) – present proof if not obvious
• New/changed UI is decent on smartphones (viewport width around 360px)

[neilkakkar]

I don't 100% get how this test shows what was going wrong? We have a person breakdown test in breakdown_cases which was working beforehand, too O.o - would you mind adding another test to breakdown_cases that demonstrates how this is different / which cases it tests?

[EDsCODE]

I don't think breakdown_cases is the right place to test this. This is broken for both funnels and trends because it's just the common query used to retrieve breakdown values. Any case that had regular properties and person properties was erroring because we call parse_prop_clauses twice but don't use different parameter keys so the second parse_prop_clauses was naming the parameters the same way. Also, the table name for the inner query was using "e" as a prefix but there was no table aliased as "e"

I think the move is to get this merged to resolve person property breakdowns and then I will continue writing out a full test suite for breakdown values. We have to keep this two query pattern and close #5186 because as @fuziontech figured out, CTEs don't work as expected on distributed tables

[neilkakkar]

Sounds reasonable, I just meant: to show how it happens in a funnel query. Not a blocker, but I think a test like that makes it clearer, that this is what goes wrong: two properties, one on persons, second on events, and the persons one gets overriden, or whatever happens.

[EDsCODE]

yeah got it. Going to merge this and add more tests