feat(funnels): Highlight significant deviations in new funnel viz #9536
Conversation
| @@ -92,8 +93,23 @@ export function FunnelStepsTable(): JSX.Element | null { | |||
| }, | |||
| { | |||
| title: 'Total conversion', | |||
| render: (_: void, breakdown: FlattenedFunnelStepByBreakdown) => | |||
| formatDisplayPercentage(breakdown?.conversionRates?.total ?? 0, true), | |||
| render: function RenderTotalConversion( | |||
There was a problem hiding this comment.
curious about when and where does 'Total conversion' show up? Not sure I ever see this. Otherwise LGTM!
There was a problem hiding this comment.
I suspect you might have not created and switched on the lemon-funnel-viz flag?
There was a problem hiding this comment.
D'oh, ofcourse. Gahh, let me go again :P
|
unrelated feedback: there's something funky going on when scrolling into this table:
|
|
Well, I don't care @neilkakkar ;) About this table at least, because that's the old one, and it's going out the window once |
|
I see it now, this is beauty :D - and covers the whole line lol, much nicer UI! |
|
I realized I had kind of confused Before
After
(the screenshots are with |
|
Hmm, I am not sure if that's what those conversion rates meant. I think they were conversion rates for success, and dropoffs (which is why they sum up to 100%, otherwise it doesn't make sense how that's possible?) But, your change makes more sense, as these numbers are more valuable/harder to compute mentally. We probably don't need to highlight both rates in a single row though, since thats too many highlights? I had this condition earlier where if one is highlighted we shouldn't highlight the other conversion rate in the same overarching column |
|
They don't actually add up to 100% in the old table, which I didn't realize before building this new table, so it probably wasn't the most intuitive experience:
Fair point with highlighting both rates! Used the same logic as before so that only one rate can end up highlighted. |
Twixes
changed the title
|
I see, makes sense then! |
* master: (137 commits) feat(cohorts): add cohort filter grammars (#9540) feat(cohorts): Backwards compatibility of groups and properties (#9462) perf(ingestion): unsubscribe from buffer topic while no events are produced to it (#9556) fix: Fix `Loading` positioning and `LemonButton` disabled state (#9554) test: Speed up backend tests (#9289) fix: LemonSpacer -> LemonDivider (#9549) feat(funnels): Highlight significant deviations in new funnel viz (#9536) docs(storybook): Lemon UI (#9426) feat: add support for list of teams to enable the conversion buffer for (#9542) chore(onboarding): cleanup framework grid experiment (#9527) fix(signup): domain provisioning on cloud (#9515) chore: split out async migrations ci (#9539) feat(ingestion): enable json ingestion for self-hosted by default (#9448) feat(cohort): add all cohort filter selectors to Storybook (#9492) feat(ingestion): conversion events buffer consumer (#9432) ci(run-backend-tests): remove CH version default (#9532) feat: Add person info to events (#9404) feat(ingestion): produce to buffer partitioned by team_id:distinct_id (#9518) fix: bring latest_migrations.manifest up to date (#9525) chore: removes unused feature flag (#9529) ...
Problem
#9412 added a new funnel viz (behind feature flag
lemon-funnel-viz), but it didn't have support for highlighting significantly different breakdowns.Changes
This should make use of the existing significance logic. Let me know if I got this right @neilkakkar.