Merge pull request #3429 from gabrielcalderon/hacktoberfest

Added FROM to explicitly chain exceptions in src/prefect/utilities

changes/pr3429.yaml

@@ -0,0 +1,5 @@
+enhancement:
+  - "Added FROM to explicitly chain exceptions in src/prefect/utilities - [#3429](https://github.com/PrefectHQ/prefect/pull/3429)"
+
+contributor:
+  - "[Juan Calderon-Perez](https://github.com/gabrielcalderon)"

src/prefect/utilities/executors.py

@@ -223,8 +223,8 @@ def run_with_ctx(*args: Any, _ctx_dict: dict, **kwargs: Any) -> Any:
 
     try:
         return fut.result(timeout=timeout)
-    except FutureTimeout:
-        raise TimeoutError("Execution timed out.")
+    except FutureTimeout as exc:
+        raise TimeoutError("Execution timed out.") from exc
 
 
 class RecursiveCall(Exception):
@@ -261,12 +261,12 @@ def wrapper(*args: Any, **kwargs: Any) -> Any:
             except RecursiveCall as exc:
                 try:
                     call_func = getattr(exc.func, "__wrapped_func__")
-                except AttributeError:
+                except AttributeError as attr_error:
                     raise RecursionError(
                         "function has not been wrapped to provide tail recursion (func={})".format(
                             exc.func
                         )
-                    )
+                    ) from attr_error
 
                 # there may be multiple nested recursive calls, we should only
                 # respond to calls for the wrapped function explicitly,

src/prefect/utilities/notifications/jira_notification.py

@@ -11,10 +11,10 @@
 
 try:
     from jira import JIRA
-except ImportError:
+except ImportError as import_error:
     raise ImportError(
         'Using `jira_notifier` requires Prefect to be installed with the "jira" extra.'
-    )
+    ) from import_error
 
 if TYPE_CHECKING:
     import prefect.engine.state

src/prefect/utilities/notifications/notifications.py

@@ -233,8 +233,10 @@ def add(x, y):
     server.login(username, password)
     try:
         server.sendmail("[email protected]", username, body)
-    except Exception:
-        raise ValueError("Email notification for {} failed".format(tracked_obj))
+    except Exception as exc:
+        raise ValueError(
+            "Email notification for {} failed".format(tracked_obj)
+        ) from exc
     finally:
         server.quit()
 

src/prefect/utilities/serialization.py

@@ -185,8 +185,8 @@ def _serialize(self, value, attr, obj, **kwargs):  # type: ignore
     def _validate_json(self, value: Any) -> None:
         try:
             json.dumps(value)
-        except TypeError:
-            raise ValidationError("Value is not JSON-compatible")
+        except TypeError as type_error:
+            raise ValidationError("Value is not JSON-compatible") from type_error
 
 
 class Nested(fields.Nested):
@@ -382,10 +382,10 @@ def _serialize(self, value, attr, obj, **kwargs):  # type: ignore
 
         try:
             qual_name = to_qualified_name(value)
-        except Exception:
+        except Exception as exc:
             raise ValidationError(
                 f"Invalid function reference, function required, got {value}"
-            )
+            ) from exc
 
         # sort matches such that the longest / most specific match comes first
         valid_bases = sorted(