Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added FROM to explicitly chain exceptions in src/prefect/utilities #3429

Merged
merged 6 commits into from
Oct 6, 2020
Merged

Added FROM to explicitly chain exceptions in src/prefect/utilities #3429

merged 6 commits into from
Oct 6, 2020

Conversation

gaby
Copy link

@gaby gaby commented Oct 5, 2020

Summary

  • Added from on each raised exception for src/prefect/utilities.
  • This PR is part of Hacktoberfest.

Changes

Checklist

This PR:

  • adds a change file in the changes/ directory (if appropriate)

@gaby gaby requested review from jcrist and joshmeek as code owners October 5, 2020 00:12
@gaby
Copy link
Author

gaby commented Oct 5, 2020

It seems like this simple change will break the tests?

@joshmeek
Copy link

joshmeek commented Oct 5, 2020

Also @gabrielcalderon one more, looks like you'll need to run black formatting 🙂

gaby added 2 commits October 5, 2020 20:56
Fix formatting.
Rename exception, since the name was already used within the scope.
@codecov
Copy link

codecov bot commented Oct 6, 2020

Codecov Report

Merging #3429 into master will not change coverage.
The diff coverage is 77.77%.

@gaby
Copy link
Author

gaby commented Oct 6, 2020

Also @gabrielcalderon one more, looks like you'll need to run black formatting 🙂

Should be good now :-)

@joshmeek joshmeek merged commit 35e489d into PrefectHQ:master Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants