Enable swinunetr-v2 #6203
Merged
Enable swinunetr-v2 #6203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: heyufan1995 <[email protected]>
heyufan1995
force-pushed
the
swinunetrv2
branch
from
0bb01de to
f4b11bc
Compare
for more information, see https://pre-commit.ci
Signed-off-by: Wenqi Li <[email protected]>
|
/black |
tangy5
reviewed
Mar 22, 2023
Signed-off-by: monai-bot <[email protected]>
|
The V2 implementation is great, one more thing to discuss here. |
|
/build |
|
/build |
jak0bw
pushed a commit
to jak0bw/MONAI
that referenced
this pull request
Mar 28, 2023
Fixes Project-MONAI#6183 . ### Description Added a "use_v2" option in swinunetr initialization. Default is false will not affect the original swinunetr. Once changed to true, will become swinunetr-v2 with 4 additional convolution block. Tested running from auto3dseg bundles, no change needed for original swinunetr, and works for swinunetr-v2 Tested running from monai research contribution repo for swinuntr, no change needed for original swinunetr, and works for swinunetr-v2 Tested TensorRT, compiled .ts file successfully. ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [ ] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [ ] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. --------- Signed-off-by: heyufan1995 <[email protected]>
jak0bw
pushed a commit
to jak0bw/MONAI
that referenced
this pull request
Mar 28, 2023
Fixes Project-MONAI#6183 . ### Description Added a "use_v2" option in swinunetr initialization. Default is false will not affect the original swinunetr. Once changed to true, will become swinunetr-v2 with 4 additional convolution block. Tested running from auto3dseg bundles, no change needed for original swinunetr, and works for swinunetr-v2 Tested running from monai research contribution repo for swinuntr, no change needed for original swinunetr, and works for swinunetr-v2 Tested TensorRT, compiled .ts file successfully. ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [ ] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [ ] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. --------- Signed-off-by: heyufan1995 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6183 .
Description
Added a "use_v2" option in swinunetr initialization. Default is false will not affect the original swinunetr.
Once changed to true, will become swinunetr-v2 with 4 additional convolution block.
Tested running from auto3dseg bundles, no change needed for original swinunetr, and works for swinunetr-v2
Tested running from monai research contribution repo for swinuntr, no change needed for original swinunetr, and works for swinunetr-v2
Tested TensorRT, compiled .ts file successfully.
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.