Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "alchemy: change file structure to modules for views and models" #2023

Conversation

tseaver
Copy link
Member

@tseaver tseaver commented Oct 21, 2015

Reverts #2022

Pending Travis fixes and discussion.

tseaver added a commit that referenced this pull request Oct 21, 2015
…fold-update

Revert "alchemy: change file structure to modules for views and models"
@tseaver tseaver merged commit b58bdbe into feature/alchemy-scaffold-update Oct 21, 2015
@tseaver tseaver deleted the revert-2022-feature/alchemy-scaffold-update branch October 21, 2015 20:23
@ergo
Copy link
Member

ergo commented Oct 21, 2015

It is failing not because my changes but because whole branch is behind master in general and httpexceptions tests fail.

The actual functionality and changes were discussed on #pyramid, I could use some help in regards of actually making the branch up to date with current master, as my git foo is really weak.

@tseaver
Copy link
Member Author

tseaver commented Oct 21, 2015

@ergo you can try:

$ git remote add upstream [email protected]:Pylons/pyramid.git
$ git fetch upstream
$ git checkout master
$ git merge upstream/master
$ git checkout alchemy-scaffold-update
$ git rebase master
$ git push -f origin alchemy-scaffold-update

Then create a new PR for your branch, and fix anything that fails on Travis before we merge it.

@mmerickel
Copy link
Member

@tseaver Sorry but he shouldn't be rebasing other people's commits on top of master. He was issuing a PR against a WIP branch that hadn't been updated in a while.

I went ahead and merged master into that branch and issued PR #2024 with it. @ergo can rebase his personal changes against that branch and issue PRs to feature/alchemy-scaffold-update to have them included in the final WIP branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants