Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "alchemy: change file structure to modules for views and models" #2023

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pyramid/scaffolds/alchemy/+package+/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ def main(global_config, **settings):
""" This function returns a Pyramid WSGI application.
"""
config = Configurator(settings=settings)
config.include('pyramid_jinja2')
config.include('.models.meta')
config.include('pyramid_chameleon')
config.include('.models')
config.add_static_view('static', 'static', cache_max_age=3600)
config.add_route('home', '/')
config.scan()
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,10 @@
from sqlalchemy import (
Column,
Index,
Integer,
Text,
)

from sqlalchemy import engine_from_config
from sqlalchemy.ext.declarative import declarative_base
from sqlalchemy.orm import sessionmaker
Expand Down Expand Up @@ -45,3 +52,11 @@ def get_dbmaker(engine):
return dbmaker


class MyModel(Base):
__tablename__ = 'models'
id = Column(Integer, primary_key=True)
name = Column(Text)
value = Column(Integer)


Index('my_index', MyModel.name, unique=True, mysql_length=255)
3 changes: 0 additions & 3 deletions pyramid/scaffolds/alchemy/+package+/models/__init__.py

This file was deleted.

16 changes: 0 additions & 16 deletions pyramid/scaffolds/alchemy/+package+/models/mymodel.py

This file was deleted.

4 changes: 2 additions & 2 deletions pyramid/scaffolds/alchemy/+package+/scripts/initializedb.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,13 @@

from pyramid.scripts.common import parse_vars

from ..models.meta import (
from ..models import (
MyModel,
Base,
get_session,
get_engine,
get_dbmaker,
)
from ..models.mymodel import MyModel


def usage(argv):
Expand Down

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,20 +1,20 @@
<!DOCTYPE html>
<html lang="\{\{request.locale_name\}\}">
<html lang="${request.locale_name}">
<head>
<meta charset="utf-8">
<meta http-equiv="X-UA-Compatible" content="IE=edge">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<meta name="description" content="pyramid web application">
<meta name="author" content="Pylons Project">
<link rel="shortcut icon" href="\{\{request.static_url('{{package}}:static/pyramid-16x16.png')\}\}">
<link rel="shortcut icon" href="${request.static_url('{{package}}:static/pyramid-16x16.png')}">

<title>Alchemy Scaffold for The Pyramid Web Framework</title>

<!-- Bootstrap core CSS -->
<link href="//oss.maxcdn.com/libs/twitter-bootstrap/3.0.3/css/bootstrap.min.css" rel="stylesheet">

<!-- Custom styles for this scaffold -->
<link href="\{\{request.static_url('{{package}}:static/theme.css')\}\}" rel="stylesheet">
<link href="${request.static_url('{{package}}:static/theme.css')}" rel="stylesheet">

<!-- HTML5 shim and Respond.js IE8 support of HTML5 elements and media queries -->
<!--[if lt IE 9]>
Expand All @@ -29,12 +29,13 @@
<div class="container">
<div class="row">
<div class="col-md-2">
<img class="logo img-responsive" src="\{\{request.static_url('{{package}}:static/pyramid.png')\}\}" alt="pyramid web framework">
<img class="logo img-responsive" src="${request.static_url('{{package}}:static/pyramid.png')}" alt="pyramid web framework">
</div>
<div class="col-md-10">
{% block content %}
<p>No content</p>
{% endblock content %}
<div class="content">
<h1><span class="font-semi-bold">Pyramid</span> <span class="smaller">Alchemy scaffold</span></h1>
<p class="lead">Welcome to <span class="font-normal">${project}</span>, an&nbsp;application generated&nbsp;by<br>the <span class="font-normal">Pyramid Web Framework {{pyramid_version}}</span>.</p>
</div>
</div>
</div>
<div class="row">
Expand Down
14 changes: 7 additions & 7 deletions pyramid/scaffolds/alchemy/+package+/tests.py_tmpl
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,10 @@ class BaseTest(unittest.TestCase):
self.config = testing.setUp(settings={
'sqlalchemy.url': 'sqlite:///:memory:'
})
self.config.include('.models.meta')
self.config.include('.models')
settings = self.config.get_settings()

from .models.meta import (
from .models import (
get_session,
get_engine,
get_dbmaker,
Expand All @@ -28,11 +28,11 @@ class BaseTest(unittest.TestCase):
self.session = get_session(transaction.manager, dbmaker)

def init_database(self):
from .models.meta import Base
from .models import Base
Base.metadata.create_all(self.engine)

def tearDown(self):
from .models.meta import Base
from .models import Base

testing.tearDown()
transaction.abort()
Expand All @@ -45,13 +45,13 @@ class TestMyViewSuccessCondition(BaseTest):
super(TestMyViewSuccessCondition, self).setUp()
self.init_database()

from .models.mymodel import MyModel
from .models import MyModel

model = MyModel(name='one', value=55)
self.session.add(model)

def test_passing_view(self):
from .views.default import my_view
from .views import my_view
info = my_view(dummy_request(self.session))
self.assertEqual(info['one'].name, 'one')
self.assertEqual(info['project'], '{{project}}')
Expand All @@ -60,6 +60,6 @@ class TestMyViewSuccessCondition(BaseTest):
class TestMyViewFailureCondition(BaseTest):

def test_failing_view(self):
from .views.default import my_view
from .views import my_view
info = my_view(dummy_request(self.session))
self.assertEqual(info.status_int, 500)
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,10 @@ from pyramid.view import view_config

from sqlalchemy.exc import DBAPIError

from ..models.mymodel import MyModel
from .models import MyModel


@view_config(route_name='home', renderer='../templates/mytemplate.jinja2')
@view_config(route_name='home', renderer='templates/mytemplate.pt')
def my_view(request):
try:
one = request.dbsession.query(MyModel).filter(MyModel.name == 'one').first()
Expand Down
Empty file.
2 changes: 1 addition & 1 deletion pyramid/scaffolds/alchemy/setup.py_tmpl
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ with open(os.path.join(here, 'CHANGES.txt')) as f:

requires = [
'pyramid',
'pyramid_jinja2',
'pyramid_chameleon',
'pyramid_debugtoolbar',
'pyramid_tm',
'SQLAlchemy',
Expand Down