Switch linux wheel compile job to mirror deploy job #601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the linux wheel compile job to mirror the configuration we use for building wheels on linux at release time. This adds 2 additional points of coverage. the first and most importantly is that python packaging on linux has stringent requitements [1] that require us to publish wheels in a specific docker image. To make sure that we don't introduce a change that breaks compilation (since there have been issues with that in the past) with that limitation we should build wheels in that environment in CI. The second aspect of additional coverage here is that it adds compilation of all supported python versions. [1] https://www.python.org/dev/peps/pep-0571/
|
err, it looks like the pulse simulator is failing in this environment (we added coverage to the verify_wheels script in #584 ) https://travis-ci.com/Qiskit/qiskit-aer/jobs/285004587#L654 This isn't a good sign because we used this exact setup for publishing the wheels in 0.4.0 |
|
After confirming this issue locally with the published wheels I've opened #602 once we have a fix for that in place, we definitely should merge this (and backport it to stable/0.4) so that we don't accidentally regress in the future. Otherwise we'll only catch this issue at release time which is when we don't want to have a failed build |
mtreinish
added
the
stable-backport-potential
atilag
added a commit
to atilag/qiskit-aer
that referenced
this pull request
Feb 11, 2020
This commit updates the linux wheel compile job to mirror the configuration we use for building wheels on linux at release time. This adds 2 additional points of coverage. the first and most importantly is that python packaging on linux has stringent requitements [1] that require us to publish wheels in a specific docker image. To make sure that we don't introduce a change that breaks compilation (since there have been issues with that in the past) with that limitation we should build wheels in that environment in CI. The second aspect of additional coverage here is that it adds compilation of all supported python versions. [1] https://www.python.org/dev/peps/pep-0571/ Co-authored-by: Juan Gomez <[email protected]>
atilag
added a commit
to atilag/qiskit-aer
that referenced
this pull request
Feb 12, 2020
This commit updates the linux wheel compile job to mirror the configuration we use for building wheels on linux at release time. This adds 2 additional points of coverage. the first and most importantly is that python packaging on linux has stringent requitements [1] that require us to publish wheels in a specific docker image. To make sure that we don't introduce a change that breaks compilation (since there have been issues with that in the past) with that limitation we should build wheels in that environment in CI. The second aspect of additional coverage here is that it adds compilation of all supported python versions. [1] https://www.python.org/dev/peps/pep-0571/ Co-authored-by: Juan Gomez <[email protected]>
atilag
added a commit
that referenced
this pull request
Feb 12, 2020
This commit updates the linux wheel compile job to mirror the configuration we use for building wheels on linux at release time. This adds 2 additional points of coverage. the first and most importantly is that python packaging on linux has stringent requitements [1] that require us to publish wheels in a specific docker image. To make sure that we don't introduce a change that breaks compilation (since there have been issues with that in the past) with that limitation we should build wheels in that environment in CI. The second aspect of additional coverage here is that it adds compilation of all supported python versions. [1] https://www.python.org/dev/peps/pep-0571/ Co-authored-by: Juan Gomez <[email protected]> Co-authored-by: Matthew Treinish <[email protected]>
hhorii
pushed a commit
to hhorii/qiskit-aer
that referenced
this pull request
Feb 28, 2020
This commit updates the linux wheel compile job to mirror the configuration we use for building wheels on linux at release time. This adds 2 additional points of coverage. the first and most importantly is that python packaging on linux has stringent requitements [1] that require us to publish wheels in a specific docker image. To make sure that we don't introduce a change that breaks compilation (since there have been issues with that in the past) with that limitation we should build wheels in that environment in CI. The second aspect of additional coverage here is that it adds compilation of all supported python versions. [1] https://www.python.org/dev/peps/pep-0571/ Co-authored-by: Juan Gomez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This commit updates the linux wheel compile job to mirror the
configuration we use for building wheels on linux at release time. This
adds 2 additional points of coverage. the first and most importantly is
that python packaging on linux has stringent requitements [1] that
require us to publish wheels in a specific docker image. To make sure
that we don't introduce a change that breaks compilation (since there
have been issues with that in the past) with that limitation we should
build wheels in that environment in CI. The second aspect of additional
coverage here is that it adds compilation of all supported python
versions.
Details and comments
[1] https://www.python.org/dev/peps/pep-0571/