[Stable] Re-Backport fixes since 0.4.0 #627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…it#590) We recently pushed out the 0.4.0 release which was our first attempt of using the wheel automation in production. There were a few issues identified by the process, first several jobs forgot to add twine to the install. This was not caught because we never tested the actual wheel upload during the dry runs. Then for the sdist job we needed to update the version of pip used in the job to actually be able to install some of aer's build dependencies. The last oversight was that we never added the additional trigger for tags to trigger the wheel jobs on azure pipelines. This meant at release time the jobs never got triggered or ran. This commit fixes all these issues so for the next release the process should all work correctly. (cherry picked from commit 83b2c72)
It appears that the newly added pulse simulator has an implicit requirement on having a newer version of numpy installed. We should encode this minimum in the aer package requirements so people don't accidently install aer with a version of numpy too old to work. Fixes Qiskit#592 (cherry picked from commit 12f97c8)
…it#596) * Added small test to verify pulse simulator working in verify_wheels.py (cherry picked from commit b0e254c) Co-authored-by: Daniel Puzzuoli <[email protected]>
Qiskit#609) (Qiskit#611) It was causing the error: Cannot import numpy.core.multiarray only on older versions of CentOS.
…kit#610) This commit updates the linux wheel compile job to mirror the configuration we use for building wheels on linux at release time. This adds 2 additional points of coverage. the first and most importantly is that python packaging on linux has stringent requitements [1] that require us to publish wheels in a specific docker image. To make sure that we don't introduce a change that breaks compilation (since there have been issues with that in the past) with that limitation we should build wheels in that environment in CI. The second aspect of additional coverage here is that it adds compilation of all supported python versions. [1] https://www.python.org/dev/peps/pep-0571/ Co-authored-by: Juan Gomez <[email protected]> Co-authored-by: Matthew Treinish <[email protected]>
Installing the qiskit-aer python package always requires terra. This is primarily because of the package namespacing the qiskit.providers package doesn't exist outside of terra. But also because the majority of the python functionality exposed via qiskit-aer depends on terra's api. We should be enforcing that when you install aer terra is installed (and at the correct version). Otherwise people could install aer and never get it working. (cherry picked from commit 1e086f9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It looks like recent changes were made to the stable branch names that deleted work done to backport fixes made since the 0.4.0 release. This commit re-backports all the fixes made to the previous stable branch so that we restore the old state. Ideally this should be rebased and merged or a merge commit used since each commit has been reviewed and is self contained so we should preserve that history as individual commits. If necessary we can directly push this to the stable branch.
Details and comments
Backported from: #589 (originally in #590), #594 (originally in #595), #588 (originally in #596), #609 (originally in #611), #601 (originally in #610) and #593 (originally in #618).