-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Relax constraints on jupyter-core and ipywidgets (#9364)
* Relax constraints on jupyter-core and ipywidgets These were originally added in #9105 and #9272 respectively, but the original problem package `seaborn` has released since then, which may have fixed things. * Fix suppressions for Jupyter warnings This removes some now-unnecessary suppressions from image-related packages, and adds the new suppression for the pyzmq problem, which is Jupyter's domain to handle. The extra environment variable in the images test run is to eagerly move to new default behaviour starting in jupyter-core 6; there is no need for us to pin the package too low, since this warning is just encouraging people to proactively test the new behaviour, and it doesn't cause our suite problems. * Use correct YAML syntax One day I'll remember this when writing environment variables in YAML files, but it's not this day.
- Loading branch information
1 parent
7955d92
commit dce9fda
Showing
3 changed files
with
10 additions
and
14 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,3 @@ | ||
# jsonschema pinning needed due nbformat==5.1.3 using deprecated behaviour in | ||
# 4.0+. The pin can be removed after nbformat is updated. | ||
jsonschema==3.2.0 | ||
|
||
# jupyter-core 5.0.0 started emitting deprecation warnings with ipywidgets via | ||
# a seaborn import. This pin can be removed when compatibility with those | ||
# packages is fixed | ||
jupyter-core==4.11.2 | ||
|
||
# ipywidgets 8.0.3 started emitting deprecation warnings via a seaborn import. | ||
# This pin can be removed when compatibility with those packages is fixed. | ||
ipywidgets<8.0.3 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters