Pin ipywidgets

[t-imamichi]

Summary

ipywidgets 8.0.3 (released on Dec 7 link) raises a deprecation warning as follows.

======================================================================
ERROR: test_plot_error_map_over_100_qubit_backend_v2 (test.python.visualization.test_gate_map.TestGateMap)
test.python.visualization.test_gate_map.TestGateMap.test_plot_error_map_over_100_qubit_backend_v2
----------------------------------------------------------------------
testtools.testresult.real._StringException: Traceback (most recent call last):
  File "/Users/ima/tasks/2_2022/qiskit/terra/test/python/visualization/test_gate_map.py", line 151, in test_plot_error_map_over_100_qubit_backend_v2
    fig = plot_error_map(backend)
  File "/Users/ima/tasks/2_2022/qiskit/terra/qiskit/utils/lazy_tester.py", line 165, in out
    return function(*args, **kwargs)
  File "/Users/ima/tasks/2_2022/qiskit/terra/qiskit/utils/lazy_tester.py", line 164, in out
    self.require_now(feature)
  File "/Users/ima/tasks/2_2022/qiskit/terra/qiskit/utils/lazy_tester.py", line 221, in require_now
    if self:
  File "/Users/ima/tasks/2_2022/qiskit/terra/qiskit/utils/lazy_tester.py", line 114, in __bool__
    self._bool = self._is_available()
  File "/Users/ima/tasks/2_2022/qiskit/terra/qiskit/utils/lazy_tester.py", line 289, in _is_available
    imported = importlib.import_module(module)
  File "/usr/local/Cellar/[email protected]/3.9.15/Frameworks/Python.framework/Versions/3.9/lib/python3.9/importlib/__init__.py", line 127, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1030, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1007, in _find_and_load
  File "<frozen importlib._bootstrap>", line 986, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 680, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 850, in exec_module
  File "<frozen importlib._bootstrap>", line 228, in _call_with_frames_removed
  File "/Users/ima/envs/dev39/lib/python3.9/site-packages/seaborn/__init__.py", line 12, in <module>
    from .widgets import *  # noqa: F401,F403
  File "/Users/ima/envs/dev39/lib/python3.9/site-packages/seaborn/widgets.py", line 6, in <module>
    from ipywidgets import interact, FloatSlider, IntSlider
  File "/Users/ima/envs/dev39/lib/python3.9/site-packages/ipywidgets/__init__.py", line 25, in <module>
    from .widgets import *
  File "/Users/ima/envs/dev39/lib/python3.9/site-packages/ipywidgets/widgets/__init__.py", line 4, in <module>
    from .widget import Widget, CallbackDispatcher, register, widget_serialization
  File "/Users/ima/envs/dev39/lib/python3.9/site-packages/ipywidgets/widgets/widget.py", line 300, in <module>
    class Widget(LoggingHasTraits):
  File "/Users/ima/envs/dev39/lib/python3.9/site-packages/traitlets/traitlets.py", line 972, in __init__
    cls.setup_class(classdict)
  File "/Users/ima/envs/dev39/lib/python3.9/site-packages/traitlets/traitlets.py", line 1009, in setup_class
    value = getattr(cls, name)
  File "/Users/ima/envs/dev39/lib/python3.9/site-packages/ipywidgets/widgets/widget.py", line 296, in __get__
    return self.fget()
  File "/Users/ima/envs/dev39/lib/python3.9/site-packages/ipywidgets/widgets/widget.py", line 324, in _active_widgets
    deprecation("Widget._active_widgets is deprecated.")
  File "/Users/ima/envs/dev39/lib/python3.9/site-packages/ipywidgets/widgets/utils.py", line 64, in deprecation
    warnings.warn(message, DeprecationWarning, stacklevel=stacklevel+1)
DeprecationWarning: Widget._active_widgets is deprecated.

Details and comments

[qiskit-bot]

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

• @Qiskit/terra-core

[coveralls]

Pull Request Test Coverage Report for Build 3656342382

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage decreased (-0.04%) to 84.556%

---

Totals
Change from base Build 3650169352:	-0.04%
Covered Lines:	63222
Relevant Lines:	74769

---

💛 - Coveralls

[Cryoris]

I'm a bit confused by this warning: I can reproduce it with running the test but not if I use the function that gives rise to the warning directly:

>>> from qiskit.providers.fake_provider import FakeParis
>>> from qiskit.visualization import plot_error_map
>>> plot_error_map(FakeParis())  # this raises the warning in the test it seems
<Figure size 2400x1800 with 5 Axes>  # no warning here!

In the ipywidgets it also seems the warning is only raised in a certain condition -- which makes me wonder if the test should be set up differently or whether it's really a issue with ipywidgets 🤔

[t-imamichi]

Yes, the condition looks complicated. This PR jupyter-widgets/ipywidgets#3569 introduced it. But I haven't figured out it yet.

[mtreinish]

Looking at that code it is definitely an issue with ipywidgets (I'm inclined to think it's a bug in their stack inspection code added in that PR) and/or seaborn. The test itself isn't doing anything suspicious in that all that is happening is that seaborn is getting imported as part of the visualization code and triggering a deprecation warning which we treat as fatal in the test suite (so we update our code when an upstream project deprecates an api. If we don't want to pin ipywidgets here the other option is to add the deprecation warnings to the exclude list: https://github.com/Qiskit/qiskit-terra/blob/main/qiskit/test/base.py#L190-L226 which I think is also valid in this case

[mtreinish]

Was there a case just pinning in the requirements list wasn't enough and we needed to pin it in the constraints file too?

[t-imamichi]

This line upgrades ipywidgets to 8.0.3 without this change of constraints.txt.
https://github.com/Qiskit/qiskit-terra/blob/ee4a5712bfac6104e3e93fc8a3ff845a3a0ddd77/.azure/test-linux.yml#L156

[mtreinish]

We probably don't need the requirements-dev.txt change in parallel then. But it doesn't hurt anything either.

[t-imamichi]

Ah, you are right... I didn't have to change in parallel.

[t-imamichi]

Thank you for looking at the code, Matthew. I didn't know about allow_DeprecationWarning_modules. You can choose the best way to fix this issue.

[mtreinish]

I'm fine with pinning it's just for testing so that works as well as anything else as long as we remember to circle back after the warnings are fixed