Interactive visualizations require internet connection #805
Comments
|
To use a JS library locally installed, implies the user have to modify the Jupyter installation manually. We think the installation process is not easy enough to force the user to modify the Jupyter installation for visual library usage. |
|
Closing this, as it appears there is no way around this without making an |
|
Actually, can you leave it open, even if the solution is not trivial and might not be short-term? It would serve as a reminder that we do want the visualizations not to require internet connection and we can track the status of future updates (a module for jupyter-related functionality that includes it based on |
|
Installing an nbextension via qiskit install would be a bit of a hack, requiring installing via jupyter in the commandline behind the scenes. It could be done, but ideally would be a different install altogether, as are other nbextensions. |
|
Yes, I was thinking of an eventual splitting and providing a jupyter-specific package, in the same spirit other suites do (as otherwise can become rather messy) - but mostly long-term and reevaluating in the future depending of how things evolve. |
This commit fixes a small oversight when qobj validation was added in Qiskit#805. The validation depends on a json schema files being present to validate against, however these weren't being included in the python package. This just adds it to the MANIFSET file to make sure we include it. Fixes Qiskit#859
|
Hi @diego-plan9 ! The future is here :) Any reevaluation? |
|
The future moves at good speed! :) Although in this particular issue (interactive visualizations) I don't think there have been many changes - I still agree that providing a jupyter-specific package that includes an extension is the sensible way to go. Any thoughts? |
|
I do agree! |
This commit fixes a small oversight when qobj validation was added in Qiskit#805. The validation depends on a json schema files being present to validate against, however these weren't being included in the python package. This just adds it to the MANIFSET file to make sure we include it. Fixes Qiskit#859
|
No need for future here. How about storing an entire JS file content (or maybe its trimmed version) in the codebase? Then inject it instead of trying to pull it from the internet. |
|
Or, we could just move everything to |
The interactive visualization functions with each of the iplot functions will stop working in the near future. The hard coded url that these functions rely on (see Qiskit#805) where the static compile js is hosted from is going to disapear in the near future. This will break these functions from working on released versions of qiskit, with no ability to fix it. This commit just deletes the functions because they won't work anymore once https://qvisualization.mybluemix.net goes away. So we can't even maintain compatbility with a deprecation window once that happens. Even if we did rehost the underlying js code somewhere else we can't rely on a static url like this in the future and the application is too large to self host in terra itself.
* Remove the interactive visualizations The interactive visualization functions with each of the iplot functions will stop working in the near future. The hard coded url that these functions rely on (see #805) where the static compile js is hosted from is going to disapear in the near future. This will break these functions from working on released versions of qiskit, with no ability to fix it. This commit just deletes the functions because they won't work anymore once https://qvisualization.mybluemix.net goes away. So we can't even maintain compatbility with a deprecation window once that happens. Even if we did rehost the underlying js code somewhere else we can't rely on a static url like this in the future and the application is too large to self host in terra itself. * Add backwards compat shims to call mpl functions While the interactive visualization functions will not work anymore to ease the transition of anyone using them this commit adds back the functions removed in the previous commit and converts them to be shims that call the matplotlib based visualization functions. The functions are also deprecated, this should at least give users a method to transition off of the iplot functions. * Fix release note section typo * Return figures from matplotlib funcs * Fix lint failures Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
* Remove the interactive visualizations The interactive visualization functions with each of the iplot functions will stop working in the near future. The hard coded url that these functions rely on (see #805) where the static compile js is hosted from is going to disapear in the near future. This will break these functions from working on released versions of qiskit, with no ability to fix it. This commit just deletes the functions because they won't work anymore once https://qvisualization.mybluemix.net goes away. So we can't even maintain compatbility with a deprecation window once that happens. Even if we did rehost the underlying js code somewhere else we can't rely on a static url like this in the future and the application is too large to self host in terra itself. * Add backwards compat shims to call mpl functions While the interactive visualization functions will not work anymore to ease the transition of anyone using them this commit adds back the functions removed in the previous commit and converts them to be shims that call the matplotlib based visualization functions. The functions are also deprecated, this should at least give users a method to transition off of the iplot functions. * Fix release note section typo * Return figures from matplotlib funcs * Fix lint failures Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit a1635c1)
* Remove the interactive visualizations The interactive visualization functions with each of the iplot functions will stop working in the near future. The hard coded url that these functions rely on (see Qiskit#805) where the static compile js is hosted from is going to disapear in the near future. This will break these functions from working on released versions of qiskit, with no ability to fix it. This commit just deletes the functions because they won't work anymore once https://qvisualization.mybluemix.net goes away. So we can't even maintain compatbility with a deprecation window once that happens. Even if we did rehost the underlying js code somewhere else we can't rely on a static url like this in the future and the application is too large to self host in terra itself. * Add backwards compat shims to call mpl functions While the interactive visualization functions will not work anymore to ease the transition of anyone using them this commit adds back the functions removed in the previous commit and converts them to be shims that call the matplotlib based visualization functions. The functions are also deprecated, this should at least give users a method to transition off of the iplot functions. * Fix release note section typo * Return figures from matplotlib funcs * Fix lint failures Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Informations
What is the current behavior?
The new interactive visualizations, introduced in #765 , require having an internet connection:
when it should be possible to have the required js reside locally. @filemaster and @Tansito, is there any overriding issue that prevents having the required js in terra?
The text was updated successfully, but these errors were encountered: