Add schema json files to sdist on package build #860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a small oversight when qobj validation was added in Qiskit#805. The validation depends on a json schema files being present to validate against, however these weren't being included in the python package. This just adds it to the MANIFSET file to make sure we include it. Fixes Qiskit#859
mtreinish
requested review from
ajavadia,
atilag,
delapuente,
diego-plan9,
ewinston and
nonhermitian
as code owners
atilag
approved these changes
Sep 4, 2018
lia-approves
pushed a commit
to edasgupta/qiskit-terra
that referenced
this pull request
Jul 30, 2019
Add schema json files to sdist on package build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This commit fixes a small oversight when qobj validation was added
in #805. The validation depends on a json schema files being present
to validate against, however these weren't being included in the
python package. This just adds it to the MANIFSET file to make sure we
include it.
Details and comments
Fixes #859