Remove execute() function #11565
Merged
Remove execute() function #11565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ucian0
requested review from
eggerdj,
wshanks,
a team,
ikkoham and
jyu00
as code owners
|
One or more of the the following people are requested to review this:
|
ElePT
reviewed
Jan 16, 2024
| @@ -11,10 +11,10 @@ | |||
| # that they have been altered from the originals. | |||
|
|
|||
| """ | |||
| Example showing how to use Qiskit-Terra at level 0 (novice). | |||
| Example showing how to use Qiskit at level 0 (no optimization). | |||
There was a problem hiding this comment.
I don't think that "level 0" referred to the optimization level, I think that this was intended as a beginner-level example (maybe remove the mention to level 0 altogether?)
There was a problem hiding this comment.
oooohh... that totally makes sense. I changed for how to use Qiskit at introduction level. in 2821c48
ElePT
added
the
Changelog: Removal
Co-authored-by: Elena Peña Tapia <[email protected]>
…rra into remove/execute/11044/1
Pull Request Test Coverage Report for Build 7638982603Warning: This coverage report may be inaccurate.We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
💛 - Coveralls |
ElePT
previously approved these changes
Jan 24, 2024
ElePT
previously approved these changes
Jan 24, 2024
|
@1ucian0 checking the docs build logs, I've realized that the API docs entry for execute needs to be removed too, that is |
|
good catch! fixing it in 7c5fc5e |
ElePT
approved these changes
Jan 24, 2024
jakelishman
added a commit
to jakelishman/qiskit-terra
that referenced
this pull request
May 20, 2024
This reference to `transpile` was mistakenly inserted as part of 1a027ac (Qiskitgh-11565); `execute` used to ignore the `transpile` step for `Schedule`/`ScheduleBlock` and submit directly to `backend.run`. I am not clear if there are actually any backends that *accept* pulse jobs anymore, but if there are, this is what the text should have been translated to.
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 20, 2024
* Remove reference to `transpile` from Pulse docs This reference to `transpile` was mistakenly inserted as part of 1a027ac (gh-11565); `execute` used to ignore the `transpile` step for `Schedule`/`ScheduleBlock` and submit directly to `backend.run`. I am not clear if there are actually any backends that *accept* pulse jobs anymore, but if there are, this is what the text should have been translated to. * Update qiskit/pulse/builder.py Co-authored-by: Will Shanks <[email protected]> --------- Co-authored-by: Will Shanks <[email protected]>
mergify bot
pushed a commit
that referenced
this pull request
May 20, 2024
* Remove reference to `transpile` from Pulse docs This reference to `transpile` was mistakenly inserted as part of 1a027ac (gh-11565); `execute` used to ignore the `transpile` step for `Schedule`/`ScheduleBlock` and submit directly to `backend.run`. I am not clear if there are actually any backends that *accept* pulse jobs anymore, but if there are, this is what the text should have been translated to. * Update qiskit/pulse/builder.py Co-authored-by: Will Shanks <[email protected]> --------- Co-authored-by: Will Shanks <[email protected]> (cherry picked from commit 8e3218b)
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 20, 2024
* Remove reference to `transpile` from Pulse docs This reference to `transpile` was mistakenly inserted as part of 1a027ac (gh-11565); `execute` used to ignore the `transpile` step for `Schedule`/`ScheduleBlock` and submit directly to `backend.run`. I am not clear if there are actually any backends that *accept* pulse jobs anymore, but if there are, this is what the text should have been translated to. * Update qiskit/pulse/builder.py Co-authored-by: Will Shanks <[email protected]> --------- Co-authored-by: Will Shanks <[email protected]> (cherry picked from commit 8e3218b) Co-authored-by: Jake Lishman <[email protected]>
ElePT
pushed a commit
to ElePT/qiskit
that referenced
this pull request
May 31, 2024
* Remove reference to `transpile` from Pulse docs This reference to `transpile` was mistakenly inserted as part of 1a027ac (Qiskitgh-11565); `execute` used to ignore the `transpile` step for `Schedule`/`ScheduleBlock` and submit directly to `backend.run`. I am not clear if there are actually any backends that *accept* pulse jobs anymore, but if there are, this is what the text should have been translated to. * Update qiskit/pulse/builder.py Co-authored-by: Will Shanks <[email protected]> --------- Co-authored-by: Will Shanks <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removal of
executewhich was deprecated in 0.46 #11044