-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove reference to transpile
from Pulse docs
#12448
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reference to `transpile` was mistakenly inserted as part of 1a027ac (Qiskitgh-11565); `execute` used to ignore the `transpile` step for `Schedule`/`ScheduleBlock` and submit directly to `backend.run`. I am not clear if there are actually any backends that *accept* pulse jobs anymore, but if there are, this is what the text should have been translated to.
jakelishman
added
documentation
Something is not clear or an error documentation
mod: pulse
Related to the Pulse module
Changelog: None
Do not include in changelog
labels
May 20, 2024
One or more of the following people are relevant to this code:
|
Pull Request Test Coverage Report for Build 9162345006Details
💛 - Coveralls |
wshanks
reviewed
May 20, 2024
Co-authored-by: Will Shanks <[email protected]>
wshanks
approved these changes
May 20, 2024
jakelishman
added
the
stable backport potential
The bug might be minimal and/or import enough to be port to stable
label
May 20, 2024
mergify bot
pushed a commit
that referenced
this pull request
May 20, 2024
* Remove reference to `transpile` from Pulse docs This reference to `transpile` was mistakenly inserted as part of 1a027ac (gh-11565); `execute` used to ignore the `transpile` step for `Schedule`/`ScheduleBlock` and submit directly to `backend.run`. I am not clear if there are actually any backends that *accept* pulse jobs anymore, but if there are, this is what the text should have been translated to. * Update qiskit/pulse/builder.py Co-authored-by: Will Shanks <[email protected]> --------- Co-authored-by: Will Shanks <[email protected]> (cherry picked from commit 8e3218b)
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 20, 2024
* Remove reference to `transpile` from Pulse docs This reference to `transpile` was mistakenly inserted as part of 1a027ac (gh-11565); `execute` used to ignore the `transpile` step for `Schedule`/`ScheduleBlock` and submit directly to `backend.run`. I am not clear if there are actually any backends that *accept* pulse jobs anymore, but if there are, this is what the text should have been translated to. * Update qiskit/pulse/builder.py Co-authored-by: Will Shanks <[email protected]> --------- Co-authored-by: Will Shanks <[email protected]> (cherry picked from commit 8e3218b) Co-authored-by: Jake Lishman <[email protected]>
ElePT
pushed a commit
to ElePT/qiskit
that referenced
this pull request
May 31, 2024
* Remove reference to `transpile` from Pulse docs This reference to `transpile` was mistakenly inserted as part of 1a027ac (Qiskitgh-11565); `execute` used to ignore the `transpile` step for `Schedule`/`ScheduleBlock` and submit directly to `backend.run`. I am not clear if there are actually any backends that *accept* pulse jobs anymore, but if there are, this is what the text should have been translated to. * Update qiskit/pulse/builder.py Co-authored-by: Will Shanks <[email protected]> --------- Co-authored-by: Will Shanks <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Changelog: None
Do not include in changelog
documentation
Something is not clear or an error documentation
mod: pulse
Related to the Pulse module
stable backport potential
The bug might be minimal and/or import enough to be port to stable
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This reference to
transpile
was mistakenly inserted as part of 1a027ac (gh-11565);execute
used to ignore thetranspile
step forSchedule
/ScheduleBlock
and submit directly tobackend.run
.I am not clear if there are actually any backends that accept pulse jobs anymore, but if there are, this is what the text should have been translated to.
Details and comments
It's not at all clear to me how accurate this documentation remains at all (if nothing else, doesn't the pulse builder return
ScheduleBlock
now?), but this is at least a fix for the change in #11565.Fix #12447.