Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reference to transpile from Pulse docs #12448

Merged
merged 2 commits into from
May 20, 2024

Conversation

jakelishman
Copy link
Member

Summary

This reference to transpile was mistakenly inserted as part of 1a027ac (gh-11565); execute used to ignore the transpile step for Schedule/ScheduleBlock and submit directly to backend.run.

I am not clear if there are actually any backends that accept pulse jobs anymore, but if there are, this is what the text should have been translated to.

Details and comments

It's not at all clear to me how accurate this documentation remains at all (if nothing else, doesn't the pulse builder return ScheduleBlock now?), but this is at least a fix for the change in #11565.

Fix #12447.

This reference to `transpile` was mistakenly inserted as part of 1a027ac
(Qiskitgh-11565); `execute` used to ignore the `transpile` step for
`Schedule`/`ScheduleBlock` and submit directly to `backend.run`.

I am not clear if there are actually any backends that *accept* pulse
jobs anymore, but if there are, this is what the text should have been
translated to.
@jakelishman jakelishman added documentation Something is not clear or an error documentation mod: pulse Related to the Pulse module Changelog: None Do not include in changelog labels May 20, 2024
@jakelishman jakelishman added this to the 1.1.1 milestone May 20, 2024
@jakelishman jakelishman requested review from eggerdj, wshanks and a team as code owners May 20, 2024 16:22
@qiskit-bot
Copy link
Collaborator

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core
  • @nkanazawa1989

@coveralls
Copy link

coveralls commented May 20, 2024

Pull Request Test Coverage Report for Build 9162345006

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 9 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.003%) to 89.614%

Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 3 93.13%
crates/qasm2/src/parse.rs 6 97.61%
Totals Coverage Status
Change from base Build 9160457388: -0.003%
Covered Lines: 62303
Relevant Lines: 69524

💛 - Coveralls

qiskit/pulse/builder.py Outdated Show resolved Hide resolved
@jakelishman jakelishman enabled auto-merge May 20, 2024 17:24
@jakelishman jakelishman added this pull request to the merge queue May 20, 2024
Merged via the queue into Qiskit:main with commit 8e3218b May 20, 2024
15 checks passed
@jakelishman jakelishman added the stable backport potential The bug might be minimal and/or import enough to be port to stable label May 20, 2024
@jakelishman jakelishman deleted the fix-execute-pulse-doc branch May 20, 2024 19:10
mergify bot pushed a commit that referenced this pull request May 20, 2024
* Remove reference to `transpile` from Pulse docs

This reference to `transpile` was mistakenly inserted as part of 1a027ac
(gh-11565); `execute` used to ignore the `transpile` step for
`Schedule`/`ScheduleBlock` and submit directly to `backend.run`.

I am not clear if there are actually any backends that *accept* pulse
jobs anymore, but if there are, this is what the text should have been
translated to.

* Update qiskit/pulse/builder.py

Co-authored-by: Will Shanks <[email protected]>

---------

Co-authored-by: Will Shanks <[email protected]>
(cherry picked from commit 8e3218b)
github-merge-queue bot pushed a commit that referenced this pull request May 20, 2024
* Remove reference to `transpile` from Pulse docs

This reference to `transpile` was mistakenly inserted as part of 1a027ac
(gh-11565); `execute` used to ignore the `transpile` step for
`Schedule`/`ScheduleBlock` and submit directly to `backend.run`.

I am not clear if there are actually any backends that *accept* pulse
jobs anymore, but if there are, this is what the text should have been
translated to.

* Update qiskit/pulse/builder.py

Co-authored-by: Will Shanks <[email protected]>

---------

Co-authored-by: Will Shanks <[email protected]>
(cherry picked from commit 8e3218b)

Co-authored-by: Jake Lishman <[email protected]>
ElePT pushed a commit to ElePT/qiskit that referenced this pull request May 31, 2024
* Remove reference to `transpile` from Pulse docs

This reference to `transpile` was mistakenly inserted as part of 1a027ac
(Qiskitgh-11565); `execute` used to ignore the `transpile` step for
`Schedule`/`ScheduleBlock` and submit directly to `backend.run`.

I am not clear if there are actually any backends that *accept* pulse
jobs anymore, but if there are, this is what the text should have been
translated to.

* Update qiskit/pulse/builder.py

Co-authored-by: Will Shanks <[email protected]>

---------

Co-authored-by: Will Shanks <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: None Do not include in changelog documentation Something is not clear or an error documentation mod: pulse Related to the Pulse module stable backport potential The bug might be minimal and/or import enough to be port to stable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No support for transpiling Schedule
4 participants